Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Projects] Fixing branch details #5048

Merged
merged 2 commits into from
Aug 4, 2021
Merged

[Projects] Fixing branch details #5048

merged 2 commits into from
Aug 4, 2021

Conversation

AlexTugarev
Copy link
Member

  1. fixes Only prebuilds for the default branch are surfaced on the projects list #5002
  2. removes arbitrary limitation of branches from server. instead applying a limit of 10 after filtering on frontend.

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlexTugarev! Looks good to merged once mock data are removed. 🍊

Not sure if mock data does override the prebuild information on the project card but this seems to work as expected.

What do you think of 🅰️ adding some truncation on the branch name and 🅱️ restructuring the timestamp information, because of the small area, as seen in the specs? Feel free to open a follow up issue for the timestamp structure. ❓

The project cards could also use some facelift as seen in the sepcs in #5002 (comment) but sounds ok to leave this out of the scope of these changes. 🧀

BEFORE AFTER
CARD-BEFORE CARD-AFTER

@roboquat
Copy link
Contributor

roboquat commented Aug 4, 2021

LGTM label has been added.

Git tree hash: 549627828f58702479f0dc3c0002097d65b69985

@roboquat
Copy link
Contributor

roboquat commented Aug 4, 2021

LGTM label has been added.

Git tree hash: 6feaa549dac4136f33a8a4d0625570438ac7310d

@roboquat roboquat added the lgtm label Aug 4, 2021
@leodido
Copy link
Contributor

leodido commented Aug 4, 2021

/hold cancel

@roboquat
Copy link
Contributor

roboquat commented Aug 4, 2021

New changes are detected. LGTM label has been removed.

@roboquat roboquat removed the lgtm label Aug 4, 2021
@AlexTugarev
Copy link
Member Author

/approve

@roboquat
Copy link
Contributor

roboquat commented Aug 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev, gtsiolis

Associated issue: #5002

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 0d6068b into main Aug 4, 2021
@roboquat roboquat deleted the at/projects-misc branch August 4, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only prebuilds for the default branch are surfaced on the projects list
4 participants