Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] Refactor containerd error handling #5221

Merged
merged 1 commit into from
Aug 16, 2021
Merged

[ws-daemon] Refactor containerd error handling #5221

merged 1 commit into from
Aug 16, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 16, 2021

No description provided.

@aledbf
Copy link
Member Author

aledbf commented Aug 16, 2021

/assign @geropl

@geropl
Copy link
Member

geropl commented Aug 16, 2021

Code looks good. Waiting for the build/preview env to perform a basic test.

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #5221 (730a846) into main (9eacb7d) will increase coverage by 23.05%.
The diff coverage is n/a.

❗ Current head 730a846 differs from pull request most recent head 93c2995. Consider uploading reports for the commit 93c2995 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5221       +/-   ##
=========================================
+ Coverage      0   23.05%   +23.05%     
=========================================
  Files         0       11       +11     
  Lines         0     1926     +1926     
=========================================
+ Hits          0      444      +444     
- Misses        0     1423     +1423     
- Partials      0       59       +59     
Flag Coverage Δ
components-ws-daemon-app 23.05% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/quota/size.go 87.30% <0.00%> (ø)
components/ws-daemon/pkg/content/tar.go 46.71% <0.00%> (ø)
components/ws-daemon/pkg/resources/controller.go 33.69% <0.00%> (ø)
components/ws-daemon/pkg/resources/dispatch.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/config.go 62.50% <0.00%> (ø)
components/ws-daemon/pkg/internal/session/store.go 19.38% <0.00%> (ø)
components/ws-daemon/pkg/content/archive.go 57.47% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go 50.73% <0.00%> (ø)
components/ws-daemon/pkg/resources/limiter.go 77.77% <0.00%> (ø)
components/ws-daemon/pkg/content/service.go 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eacb7d...93c2995. Read the comment docs.

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the preview env finally deployed I tested:

  • starting a workspace
  • killing containerd on the node
    ✔️

@roboquat roboquat added the lgtm label Aug 16, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 616ffee2926cab91d4a0112daf03bfcb5c58d999

@geropl
Copy link
Member

geropl commented Aug 16, 2021

/approve no-issue

1 similar comment
@aledbf
Copy link
Member Author

aledbf commented Aug 16, 2021

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, geropl

Associated issue requirement bypassed by: aledbf, geropl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit cd38227 into main Aug 16, 2021
@roboquat roboquat deleted the aledbf/ready branch August 16, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants