Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Show loading indicator when switching git providers to add a new project #6711

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Nov 15, 2021

Description

Show loading indicator when switching git providers to add a new project

Related Issue(s)

Fixes #6654

How to test

  1. Go to https://jx-switch-load.staging.gitpod-dev.com/new
  2. Switch between Git providers (hint: click on "change" next to github.com or gitlab.com near the top)

The switch should show the loading indicator while loading (and not the previous list of repos from the old provider)

Release Notes

[dashboard] Show loading indicator when switching git providers to add a new project

Documentation

/uncc

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Nov 15, 2021

/werft run

👍 started the job as gitpod-build-jx-switch-load.1

@jankeromnes jankeromnes marked this pull request as ready for review November 15, 2021 15:20
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Nov 15, 2021

There was already a loading state implemented, I just reactivated it when switching providers:

Screenshot 2021-11-15 at 16 29 57

Could potentially be made prettier though. 😇 @laushinka @gtsiolis any thoughts? ✨

@laushinka
Copy link
Contributor

laushinka commented Nov 15, 2021

I can't authorize GitHub in this preview env but when switching to GitLab I can see the loading page 🎉

@laushinka
Copy link
Contributor

Approving but holding off on the lgtm until @gtsiolis takes a look.

/approve

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: ebe6527ea1084586472c11272d250f63e177b76b

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: laushinka

Associated issue: #6654

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit c009480 into main Nov 16, 2021
@roboquat roboquat deleted the jx/switch-load branch November 16, 2021 08:37
@laushinka
Copy link
Contributor

laushinka commented Nov 16, 2021

Oh oops I saw the banner that it still needs my review even after approving, so I did that, turns out it then adds the lgtm label 😅 Sorry if @gtsiolis still wanted to take a look!

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Nov 16, 2021

That's perfect, many thanks for the review @laushinka! 🙏 😁

I also flagged @gtsiolis in case there is an opportunity to improve the design of the loading indicator, but we can also do that as a follow-up / later on. The most important thing was to use the loading indicator appropriately, which fixes the issue. ✅

@gtsiolis
Copy link
Contributor

gtsiolis commented Nov 16, 2021

Thanks @jankeromnes @laushinka! 🏓

FWIW, just tried this in staging and this looks like a great MVC (minimum viable change) iteration. ➿

  1. DOES. THE. JOB. ✔️
  2. REUSES. EXISTING. PATTERN. ✔️

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a loading indicator when switching git providers to add new project
4 participants