Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jetbrains] Add PhpStorm IDE #7059

Merged
merged 1 commit into from
Dec 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/jetbrains-updates.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,10 @@ jobs:
productId: pycharm
productCode: PCP
productType: release
phpstorm:
uses: gitpod-io/gitpod/.github/workflows/jetbrains-updates-template.yml@main
with:
productName: PhpStorm
productId: phpstorm
productCode: PS
productType: release
7 changes: 7 additions & 0 deletions chart/templates/server-ide-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,13 @@ options:
logo: "https://upload.wikimedia.org/wikipedia/commons/1/1d/PyCharm_Icon.svg"
notes: ["While in beta, when you open a workspace with PyCharm you will need to use the password “gitpod”."]
image: {{ (include "gitpod.comp.imageFull" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.desktopIdeImages.pycharm)) }}
phpstorm:
orderKey: "07"
title: "PhpStorm"
type: "desktop"
logo: "https://upload.wikimedia.org/wikipedia/commons/c/c9/PhpStorm_Icon.svg"
notes: ["While in beta, when you open a workspace with PhpStorm you will need to use the password “gitpod”."]
image: {{ (include "gitpod.comp.imageFull" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.desktopIdeImages.phpstorm)) }}

defaultIde: "code"
defaultDesktopIde: "code-desktop"
Expand Down
2 changes: 2 additions & 0 deletions chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,8 @@ components:
imageName: "ide/goland"
pycharm:
imageName: "ide/pycharm"
phpstorm:
imageName: "ide/phpstorm"
supervisor:
imageName: "supervisor"
dockerUp:
Expand Down
1 change: 1 addition & 0 deletions components/BUILD.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ packages:
- components/ide/jetbrains/image:intellij
- components/ide/jetbrains/image:goland
- components/ide/jetbrains/image:pycharm
- components/ide/jetbrains/image:phpstorm
- components/ide/theia:docker
- components/image-builder:docker
- components/image-builder-mk3:docker
Expand Down
26 changes: 26 additions & 0 deletions components/ide/jetbrains/image/BUILD.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ packages:
- :intellij
- :goland
- :pycharm
- :phpstorm

- name: intellij
type: docker
srcs:
Expand All @@ -28,6 +30,7 @@ packages:
image:
- ${imageRepoBase}/ide/intellij:${version}
- ${imageRepoBase}/ide/intellij:commit-${__git_commit}

- name: goland
type: docker
srcs:
Expand All @@ -49,6 +52,7 @@ packages:
image:
- ${imageRepoBase}/ide/goland:${version}
- ${imageRepoBase}/ide/goland:commit-${__git_commit}

- name: pycharm
type: docker
srcs:
Expand All @@ -70,3 +74,25 @@ packages:
image:
- ${imageRepoBase}/ide/pycharm:${version}
- ${imageRepoBase}/ide/pycharm:commit-${__git_commit}

- name: phpstorm
type: docker
srcs:
- "startup.sh"
- "supervisor-ide-config_phpstorm.json"
- "status/go.mod"
- "status/main.go"
deps:
- components/ide/jetbrains/backend-plugin:plugin
argdeps:
- imageRepoBase
config:
dockerfile: leeway.Dockerfile
metadata:
helm-component: workspace.desktopIdeImages.phpstorm
buildArgs:
JETBRAINS_BACKEND_URL: "https://download.jetbrains.com/webide/PhpStorm-2021.3.tar.gz"
SUPERVISOR_IDE_CONFIG: supervisor-ide-config_phpstorm.json
image:
- ${imageRepoBase}/ide/phpstorm:${version}
- ${imageRepoBase}/ide/phpstorm:commit-${__git_commit}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"entrypoint": "/ide-desktop/startup.sh",
"entrypointArgs": [ "Open in PhpStorm" ],
"readinessProbe": {
"type": "http",
"http": {
"port": 24000,
"path": "/status"
}
}
}
10 changes: 9 additions & 1 deletion installer/pkg/components/server/ide-configmap.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,15 @@ func ideconfigmap(ctx *common.RenderContext) ([]runtime.Object, error) {
Type: typeDesktop,
Logo: "https://upload.wikimedia.org/wikipedia/commons/1/1d/PyCharm_Icon.svg", // TODO(clu): Serve logo from our own components instead of using this wikimedia URL.
Notes: []string{"While in beta, when you open a workspace with PyCharm you will need to use the password “gitpod”."},
Image: common.ImageName(ctx.Config.Repository, workspace.PyCharmDesktopIdeImage, ctx.VersionManifest.Components.Workspace.DesktopIdeImages.GoLandImage.Version),
Image: common.ImageName(ctx.Config.Repository, workspace.PyCharmDesktopIdeImage, ctx.VersionManifest.Components.Workspace.DesktopIdeImages.PyCharmImage.Version),
},
"phpstorm": {
OrderKey: pointer.String("07"),
Title: "PhpStorm",
Type: typeDesktop,
Logo: "https://upload.wikimedia.org/wikipedia/commons/c/c9/PhpStorm_Icon.svg", // TODO(clu): Serve logo from our own components instead of using this wikimedia URL.
Notes: []string{"While in beta, when you open a workspace with PhpStorm you will need to use the password “gitpod”."},
Image: common.ImageName(ctx.Config.Repository, workspace.PhpStormDesktopIdeImage, ctx.VersionManifest.Components.Workspace.DesktopIdeImages.PhpStormImage.Version),
},
},
DefaultIDE: "code",
Expand Down
1 change: 1 addition & 0 deletions installer/pkg/components/workspace/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ const (
IntelliJDesktopIDEImage = "ide/intellij"
GoLandDesktopIdeImage = "ide/goland"
PyCharmDesktopIdeImage = "ide/pycharm"
PhpStormDesktopIdeImage = "ide/phpstorm"
DockerUpImage = "docker-up"
SupervisorImage = "supervisor"
SupervisorPort = 22999
Expand Down
1 change: 1 addition & 0 deletions installer/pkg/config/versions/versions.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ type Components struct {
IntelliJImage Versioned `json:"intellij"`
GoLandImage Versioned `json:"goland"`
PyCharmImage Versioned `json:"pycharm"`
PhpStormImage Versioned `json:"phpstorm"`
} `json:"desktopIdeImages"`
} `json:"workspace"`
WSDaemon struct {
Expand Down