Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Add MINIO_SKIP_CLIENT=yes to minio #8270

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

corneliusludmann
Copy link
Contributor

Description

This skips MinIO client configuration in the minio container. The client configuration leads to a crash loop on air-gap installations and since we don't use the minio client in Gitpod we simply skip the client configuration.

Related Issue(s)

Fixes #8269

How to test

The only way to test this is to install a Gitpod installation with built-in MinIO and verify that everything still works. I did this and everything works.

Release Notes

[self-hosted] Skip MinIO client configuration in the MinIO container because it breaks air-gap installations.

Meta

/werft no-preview

This skips MinIO client configuration in the minio container. The client configuration leads to a crash loop on air-gap installations and since we don't use the minio client in Gitpod we simply skip the client configuration.

/werft no-preview
@corneliusludmann corneliusludmann requested a review from a team February 17, 2022 09:48
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Feb 17, 2022
@roboquat roboquat merged commit 064837a into main Feb 17, 2022
@roboquat roboquat deleted the clu/installer-set-8269 branch February 17, 2022 09:50
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #8270 (d81f0ed) into main (ce70183) will decrease coverage by 23.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #8270       +/-   ##
==========================================
- Coverage   31.21%   8.15%   -23.07%     
==========================================
  Files          39      31        -8     
  Lines        5908    2184     -3724     
==========================================
- Hits         1844     178     -1666     
+ Misses       3924    2003     -1921     
+ Partials      140       3      -137     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-installer-raw-app 5.62% <ø> (?)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-supervisor-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/supervisor/ssh.go
components/supervisor/pkg/ports/served-ports.go
components/supervisor/pkg/dropwriter/dropwriter.go
components/local-app/pkg/auth/auth.go
components/supervisor/pkg/supervisor/user.go
components/supervisor/pkg/supervisor/config.go
components/supervisor/pkg/config/gitpod-config.go
components/supervisor/pkg/ports/ports-config.go
...mponents/supervisor/pkg/supervisor/notification.go
components/supervisor/pkg/supervisor/services.go
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce70183...d81f0ed. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/XS team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[installer] Set MINIO_SKIP_CLIENT to yes for minio (needed for air-gap installations)
3 participants