Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubecdl] Fix server name pattern #8770

Merged
merged 1 commit into from
Mar 11, 2022
Merged

[kubecdl] Fix server name pattern #8770

merged 1 commit into from
Mar 11, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 11, 2022

Description

New generations dropped the -external sufix.

Release Notes

[kubecdl] Fix server name pattern

kylos101
kylos101 previously approved these changes Mar 11, 2022
Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #8770 (9799bca) into main (f699ffb) will decrease coverage by 1.13%.
The diff coverage is n/a.

❗ Current head 9799bca differs from pull request most recent head 941aa74. Consider uploading reports for the commit 941aa74 to get more accurate results

@@            Coverage Diff             @@
##             main    #8770      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 965805e into main Mar 11, 2022
@roboquat roboquat deleted the aledbf/cdl branch March 11, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants