Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[public-api] Fix codegen #9605

Merged
merged 1 commit into from
Apr 28, 2022
Merged

[public-api] Fix codegen #9605

merged 1 commit into from
Apr 28, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Apr 28, 2022

Description

With the move to Go 1.18, we can no longer do go get outside of a module file. Our dependencies are also not runnable tools so can't do go install. See release notes.

  • tools.go is introduced to reference the dependencies and enable go mod tidy to work.

Related Issue(s)

Fixes public-api codegen.

How to test

Release Notes

Fix public-api codegeneration.

Documentation

NONE

@easyCZ easyCZ requested a review from a team April 28, 2022 07:46
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 28, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Apr 28, 2022

Some generates files are also changed. This is due to the upgraded dependencies in previous PRs. Unfortunately, we don't have a codegen-drift-check on CI so this slipped through.

Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should extend this to the other API packages

@roboquat roboquat merged commit d2bdfa9 into main Apr 28, 2022
@roboquat roboquat deleted the mp/public-api-fix-codegen branch April 28, 2022 11:28
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants