[installer] Add disableMigration experimental config
#9793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-farries
force-pushed
the
af/installer-disable-migration
branch
3 times, most recently
from
a4ef522
to
bc9692a
Compare
geropl
reviewed
May 5, 2022
| @@ -18,6 +19,10 @@ import ( | |||
| var initScriptFiles embed.FS | |||
|
|
|||
| func configmap(ctx *common.RenderContext) ([]runtime.Object, error) { | |||
| if disableMigration := common.IsDatabaseMigrationEnabled(ctx); disableMigration { | |||
geropl
reviewed
May 5, 2022
| @@ -20,6 +20,10 @@ import ( | |||
| var initScriptFiles embed.FS | |||
|
|
|||
| func configmap(ctx *common.RenderContext) ([]runtime.Object, error) { | |||
| if disableMigration := common.IsDatabaseMigrationEnabled(ctx); disableMigration { | |||
geropl
reviewed
May 5, 2022
| @@ -19,6 +20,10 @@ import ( | |||
| ) | |||
|
|
|||
| func job(ctx *common.RenderContext) ([]runtime.Object, error) { | |||
| if disableMigration := common.IsDatabaseMigrationEnabled(ctx); disableMigration { | |||
geropl
reviewed
May 5, 2022
| @@ -15,6 +15,10 @@ import ( | |||
| ) | |||
|
|
|||
| func job(ctx *common.RenderContext) ([]runtime.Object, error) { | |||
| if disableMigration := common.IsDatabaseMigrationEnabled(ctx); disableMigration { | |||
added 2 commits
May 5, 2022 13:37
Use it to skip rendering: * the `migration' job. * the `dbinit-session` job. * the `dbinit-scripts` configmaps.
Test that the objects are/are not rendered when the `disableMigration` config flag is set.
andrew-farries
force-pushed
the
af/installer-disable-migration
branch
from
bc9692a
to
7e82584
Compare
corneliusludmann
approved these changes
May 5, 2022
|
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-af-installer-disable-migration.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of the Webapp team's epics for Q2 is to use the Gitpod installer to deploy to Gitpod SaaS. In order to do that we will need to add additional configuration to the installer to make the output suitable for a SaaS deployment as opposed to a self-hosted deployment.
This PR adds an extra
disableDbMigrationconfig flag underexperimental.webapp. When set, the flag causes the installer not to render:dbinit-sessionjobmigrationsjobdb-init-scriptsconfigmapsWe do this because for Gitpod SaaS, Werft runs the migrations as part of the release process.
Related Issue(s)
Part of #9097
How to test
Create an installer config file containing this
experimentalsection:Get a
versions.yamlfor use with the installer:Then invoke the installer as:
The resources mentioned above will not be part of the rendered output.
Release Notes
Documentation
None.