Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitLab logo #9859

Merged
merged 1 commit into from
May 9, 2022
Merged

Update GitLab logo #9859

merged 1 commit into from
May 9, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented May 9, 2022 •
edited
Loading

Description

Logo update for GitLab, see relevant blog post. 🍊

See also relevant changes in https://github.com/gitpod-io/website/pull/2001. 🪂

How to test

  1. Open /workspaces as anonymous user and notice the new GitLab logo on the providers list.
  2. Adittionally, try creating a new project and notice the new GitLab logo when selecting a different provider.

You can safely ignore the provider order in the screenshots below (production vs. preview environment) which is deliberately different.

Screenshots

BEFORE AFTER
Screenshot 2022-05-09 at 11 45 26 AM Screenshot 2022-05-09 at 11 45 33 AM
Screenshot 2022-05-09 at 11 45 16 AM Screenshot 2022-05-09 at 11 45 46 AM

Release Notes

Update GitLab logo

@gtsiolis gtsiolis requested a review from a team May 9, 2022 08:50
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 9, 2022
AlexTugarev
AlexTugarev approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roboquat roboquat merged commit 705e1ea into main May 9, 2022
@roboquat roboquat deleted the gt/update-gitlab-logo branch May 9, 2022 09:38
@gtsiolis
Copy link
Contributor Author

gtsiolis commented May 9, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Thanks for taking a look, @AlexTugarev! 🏀

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtsiolis @AlexTugarev @roboquat