Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable git integrations of Bitbucket for self-hosted Gitpod #9894

Merged
merged 2 commits into from
May 11, 2022
Merged

Enable git integrations of Bitbucket for self-hosted Gitpod #9894

merged 2 commits into from
May 11, 2022

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented May 10, 2022 •
edited
Loading

Fixes #9172

How to test

  1. First, log in using GitHub/GitLab
  2. Switch to Integrations and create a custom Git Integration for bitbucket.org
Enable git integrations of Bitbucket for self-hosted Gitpod.

Note for reviewers

Initially the branch of this PR contains an extra commit (3007c91) which is meant to be removed after testing.

@AlexTugarev AlexTugarev force-pushed the alex/self-hosted-add-bitbucket-9172 branch from c7350f1 to 3007c91 Compare May 10, 2022 10:20
@roboquat roboquat added size/M and removed size/S labels May 10, 2022
@AlexTugarev
Copy link
Member Author

AlexTugarev commented May 10, 2022 •
edited
Loading

/hold

@AlexTugarev AlexTugarev force-pushed the alex/self-hosted-add-bitbucket-9172 branch from 3007c91 to e8233ea Compare May 10, 2022 10:22
@AlexTugarev AlexTugarev marked this pull request as ready for review May 10, 2022 11:44
@AlexTugarev AlexTugarev requested a review from a team May 10, 2022 11:44
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 10, 2022
@AlexTugarev
Copy link
Member Author

@jldec, have a look, please!

jldec
jldec approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@jldec jldec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thank you @AlexTugarev
Configured OAuth consumer for a bitbucket.org workspace under my own account

Copied Permissions from the bitbucket.org config used on gitpod.io (see image below)
Screenshot 2022-05-11 at 10 28 27

Users will see confirmation like this
Screenshot 2022-05-11 at 10 31 16

@AlexTugarev AlexTugarev force-pushed the alex/self-hosted-add-bitbucket-9172 branch from 10386f3 to 5ebd3f0 Compare May 11, 2022 11:02
@AlexTugarev
Copy link
Member Author

/hold cancel

@roboquat roboquat merged commit 7ca8c86 into main May 11, 2022
@roboquat roboquat deleted the alex/self-hosted-add-bitbucket-9172 branch May 11, 2022 13:19
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jldec jldec jldec approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[self-hosted] Add bitbucket.org to the list of auth providers configurable during Gitpod install
3 participants
@AlexTugarev @jldec @roboquat