test: begin implementing basic tests #148
Conversation
|
Awesome @andrewda! |
|
That's how I want to do it @alejandronanez. Unfortunately, Enzyme does not support React v16 (until it's officially released, not in alpha) which React-Native 0.46 uses for some silly reason. See more here: enzymejs/enzyme#928. I think it might be best to not merge this in until v16 is officially released later this summer. |
|
Oh, I didn't know about that compat issue :( |
|
@alejandronanez Agreed! Will keep this PR as WIP until then. React v16 should hopefully be released within the next couple weeks, and the next version of RN a few days after. |
andrewda
changed the title
|
React 16 and Enzyme 3 are officially released! 🎉 I'll give Enzyme 3 a shot today. Hopefully React-Native upgrades to React 16 soon! |
|
@andrewda awesome! |
| "react-native-htmlview": "^0.12.0", | ||
| "react-native-i18n": "^2.0.4", | ||
| "react-native-material-design-searchbar": "^1.1.4", | ||
| "react-native-parallax-scroll-view": "^0.19.0", | ||
| "react-native-mock": "https://github.com/shqld/react-native-mock/tarball/master", | ||
| "react-native-parallax-scroll-view": "https://github.com/mini-eggs/react-native-parallax-scroll-view/tarball/react16-support", |
There was a problem hiding this comment.
Definitely need to wait until these are all actually fixed before merging this. Using these forks is just to get it to work, not a permanent (or acceptable) solution.
| "react-native-photo-view": "^1.5.2", | ||
| "react-native-safari-view": "^2.0.0", | ||
| "react-native-search-bar": "^3.0.0", | ||
| "react-native-search-bar": "https://github.com/andrewda/react-native-search-bar/tarball/master", |
| "react-native-syntax-highlighter": "^1.2.1", | ||
| "react-native-table-component": "^1.0.5", | ||
| "react-native-table-component": "https://github.com/jaynakus/react-native-table-component/tarball/master", |
|
For now I've only went ahead and tested |
andrewda
changed the title
|
Moved to #407 to make contributions easier. |
Fixes #112.