Set default user agent #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks man. I'll talk about the test failure over in #202. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request sets the default user agent as
Mozilla/5.0 (compatible; HTML Proofer/2.1.0}; +https://github.com/gjtorikian/html-proofer). The user agent screen is based off of GoogleBot's user agent format. This should allow us to bypass Typhoeus-specific blocks on WordPress and Drupal.Via @gjtorikian over in #200 (comment):
I believe as long as we're honest, and identify as HTML-Proofer (which can be blocked if that is in fact the desired behavior), we're fine. I don't think we should e.g., have a random string as a user agent hash. I suspect the services are blocking Typhoeus to prevent scraping, which is not what we're doing here.
Fixes #197. Fixes #200.