Relative images matter #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,6 +43,7 @@ def run | |||
|
|
|||
| def self.create_nokogiri(path) | |||
| path << "/index.html" if File.directory? path # support for Jekyll-style links | |||
| content = File.open(path, "rb") {|f| f.read } | |||
| Nokogiri::HTML(File.read(path)) | |||
There was a problem hiding this comment.
Should be Nokogiri::HTML(content), ugh.
riccardoporreca
added a commit
to riccardoporreca/html-proofer
that referenced
this pull request
Mar 14, 2023
* Most of the logic is legacy from the very early HTMLProofer, and is irrelevant not since `@filename` can only be the file where the link is defined, with `File.join` properly handling both same-directory, nested, and parent links, together with the ultimate `File.expand_path` in `absolute_path. * The legacy logic comes pretty much from gjtorikian#6 and gjtorikian#23. * This way we can also avoid `File.exist`, which can ultimately be delegated to checking the existence, not constructing the path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22
Fixes github/training.github.com#164