Remove compiler warnings when compiled with 0.14 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rewrite is needed because of gleam-lang/gleam#989 Once the above issue is fixed this can be rewritten as an alternative case clause again.
The compiler complains that the imported Port variable is unused. The problem stems from Port being shadowed by a local type constructor. Explicitly use port.Port where appropriate
|
Thank you for this, I have not forgotten about this PR! I'm waiting a little bit until I have time to investigate the issues you've found here, should be soon |
lpil
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing compiler warnings from gleam/otp when compiled with gleam 0.14.
Some comments:
supervisor.gleamis due to a bug (Compiler warns of variable not used when alternative case clauses are present gleam#989)gleam/opt/port.{Port}might mask another problem.Portis used as a constructor in another type in the module but it is actuallyport.Portthat should be used (I think). I'd expect the compiler to fail here because of ambiguous use of types. I worked around the warning by using the type explicitlyprocess_test.gleamrelating toExitStatus. As a quick workaround I add theExitStatusto theopen_portfunction. It passes the unit tests but I don't know if there are any side effects. TheExitStatusflags makes the port send an exit status command to the port process when the external command exits. An alternative could be to remove thePortSettingtype completely and just send an empty list. To some degree I don't know if I agree with the warning as it is quite nice to be able to document all the options in a type even if you are not using them. Perhaps it doesn't matter much for a test module and that you normally would use a public type in this case.I've done the changes in separate commits based on the comments above, if anything need amending.