Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to not have the Output panel open every time I save? #25

Closed
gavin310 opened this issue Jan 30, 2021 · 12 comments
Closed

Possible to not have the Output panel open every time I save? #25

gavin310 opened this issue Jan 30, 2021 · 12 comments

Comments

@gavin310
Copy link

In the old Live SASS Compiler extension, when I would save my SASS file it would render to CSS and the only visual indication was the green "Success" message would show briefly. After installing this version, every time I save my SASS file the Output panel pops up and I have to close it. Is there a way to prevent the Output panel from opening every time I save my file?

@enoversum
Copy link

@gavin310 Know exactly what you mean. Best would be an option to only show it on error detection. You could disable it completely by setting liveSassCompile.settings.showOutputWindow to false, see https://github.com/glenn2223/vscode-live-sass-compiler/blob/master/docs/settings.md - but that would probably disable messages on detected errors as well, right, @glenn2223 ?

@gavin310
Copy link
Author

Thanks for the tip @enoversum ! You're right that when this setting is false, when there's an error the output window won't show. I tried clicking on the red "Error" text, but that doesn't show the output window either. Unfortunately I'm not talented enough that I don't need error messages, so it would be great if the output window could only show when it needs to (on errors). Or, just having the output window show when you click on the red "Error" text could work too.

@glenn2223
Copy link
Owner

Hey @gavin310, thanks for contributing to making this extension even better!!

You could disable it completely by setting liveSassCompile.settings.showOutputWindow to false

@enoversum is right, setting this to false will hide the output all the time (including on error), but the info is still logged and can be accessed

You can open the output:

  1. With the liveSassCompile.command.openOutputWindow command (F1 then type some of the above or Live Sass: Open Live Sass Output Window)
  2. Clicking the error warning icons at the bottom far left, then choose the Output tab and change the drop down to Live Sass

I tried clicking on the red "Error" text, but that doesn't show the output window either.

This should definitely be a feature. Clicking on the Success or Error should open the output window. Will add this plus fix another for v4.4.0 which I'll try to get on tonight

Note

static compilationError(isWatching: boolean): void {
StatusBarUi.statusBarItem.text = `$(x) Error`;
StatusBarUi.statusBarItem.color = "#ff0033";
StatusBarUi.statusBarItem.command = null;


I think I need to readdress the outputting in the extension.

I will open a new issue with my initial thoughts and assign it the v5 milestone

@enoversum
Copy link

enoversum commented Jan 30, 2021

@glenn2223 Make sure you still get some free time, with all the effort you put into this beautiful extension :) . As for the feature, yeah, that would be perfect.

@gavin310 If you are looking for a quick solution for panel hiding, possibly for other panel message as well, you could try this extension: https://marketplace.visualstudio.com/items?itemName=sirmspencer.vscode-autohide

@gavin310
Copy link
Author

That's awesome @glenn2223 , that's for working on it so quickly! Just being able to click on the Success/Error caption to bring up the output would be pretty cool.

@enoversum Thanks for that tip!

glenn2223 added a commit that referenced this issue Jan 31, 2021
When the status bar shows an error or success message, it can be clicked to open the Live Sass Output Window
glenn2223 added a commit that referenced this issue Jan 31, 2021
## 4.4.0 - 2021-01-31

### Added
- New setting: `liveSassCompile.settings.forceBaseDirectory` #25
  - A new setting that can help performance in large projects with few Sass/Scss files.
  - **Note:** multi-root workspace with different folder structures can not use this efficiently (See [setting note](https://github.com/glenn2223/vscode-live-sass-compiler/blob/1d043a0541008dfa2b53c492f6a76dce4e3d9909/docs/settings.md) & [VS Code Feature Request](microsoft/vscode#115482) (:+1: it) )
- New feature: The status bar `Error` and `Success` messages can be clicked which will open the Output Window #25

### Updates
- `autoprefixer` from `10.2.1` to `10.2.4`
  - Small bug fixes (nothing user facing)
- Various dev-dependancy updates

### Fixed
- Part fix: Slwo file handling #22. Full fix in v5 as some small breaking changes
  - The glob pattern matcher is causing bottlenecks, reducing load calls with small patch. However moving away from glob is the end-game (which will be happening in v5)
- Fix: `compileCurrentSass` shows wrong message on fail
  - When you run `compileCurrentSass` and it would fail (for whatever reason) it would cause the output to show `Success` rather than `Error` (just the output was wrong, nothing else)
- Fix: Status bar inconsistancies during display changes
  - When command bar is changing between visuals it was possible to cause the status and the shown message to be out of sync (due to clicks while setTimeouts are pending), the setup also meant you couldn't sync them again (unless you did a manual compile command)
@glenn2223 glenn2223 mentioned this issue Jan 31, 2021
glenn2223 added a commit that referenced this issue Jan 31, 2021
## 4.4.0 - 2021-01-31

### Added
- New setting: `liveSassCompile.settings.forceBaseDirectory` #25
  - A new setting that can help performance in large projects with few Sass/Scss files.
  - **Note:** multi-root workspace with different folder structures can not use this efficiently (See [setting note](https://github.com/glenn2223/vscode-live-sass-compiler/blob/1d043a0541008dfa2b53c492f6a76dce4e3d9909/docs/settings.md) & [VS Code Feature Request](microsoft/vscode#115482) (:+1: it) )
- New feature: The status bar `Error` and `Success` messages can be clicked which will open the Output Window #25

### Updates
- `autoprefixer` from `10.2.1` to `10.2.4`
  - Small bug fixes (nothing user facing)
- Various dev-dependancy updates

### Fixed
- Part fix: Slow file handling #22. Full fix in v5 as some small breaking changes
  - The glob pattern matcher is causing bottlenecks, reducing load calls with small patch. However moving away from glob is the end-game (which will be happening in v5)
- Fix: `compileCurrentSass` shows wrong message on fail
  - When you run `compileCurrentSass` and it would fail (for whatever reason) it would cause the output to show `Success` rather than `Error` (just the output was wrong, nothing else)
- Fix: Status bar inconsistancies during display changes
  - When command bar is changing between visuals it was possible to cause the status and the shown message to be out of sync (due to clicks while setTimeouts are pending), the setup also meant you couldn't sync them again (unless you did a manual compile command)
@glenn2223
Copy link
Owner

v4.4.0 will be up shortly

Closing

@glenn2223
Copy link
Owner

Any input on #26 would be appreciated 😄

@gavin310
Copy link
Author

gavin310 commented Feb 2, 2021

Any input on #26 would be appreciated 😄

It's working great! I had a small issue at the beginning where the red "Error" text was going away after only about a second, but after completely closing and reopening VSCode it's working better and gives me enough time to click the message.

The whole process and experience with the extension is so much more seamless and unobtrusive, I love it :)

@enoversum
Copy link

Any input on #26 would be appreciated 😄

I can only second @gavin310 here - it's now very fluid, and lovely to have that input window out of the way. No problems whatsoever. Even with the extension I mentioned above, the output window would still pop up and then disappear after typing (that's how the extension works). But this is now a lot better for the compiler.

@glenn2223
Copy link
Owner

Thanks for the input on this new feature. Glad you like it 😄

#26 is actually a different issue talking about an overhaul to the output window

@gavin310
Copy link
Author

gavin310 commented Feb 3, 2021

Thanks for the input on this new feature. Glad you like it 😄

#26 is actually a different issue talking about an overhaul to the output window

Oh, I didn't realize the output window was overhauled. I hadn't been paying attention to it. I'll check it out today

@glenn2223
Copy link
Owner

Oh, I didn't realize the output window was overhauled. I hadn't been paying attention to it. I'll check it out today

No, sorry if I wasn't clear. It's just an issue raised to discuss the possibility of overhauling the log. Making sure it's considered a useful/viable change before I commit to it for v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants