Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewCompiler: Source maps broken #276

Closed
florianPopulaer opened this issue Feb 24, 2023 · 3 comments · Fixed by #277
Closed

NewCompiler: Source maps broken #276

florianPopulaer opened this issue Feb 24, 2023 · 3 comments · Fixed by #277

Comments

@florianPopulaer
Copy link

I enabled the new compiler: "liveSassCompile.settings.useNewCompiler" : true

Now source maps are broken. The browser only shows the css file and no line number, instead of the corresponding scss file including the line number.

old complier: _layout.scss:17 (that is the correct scss partial, with line number)
new compiler: backend.css:1 (that is the main, combined file)
@glenn2223
Copy link
Owner

I have identified the issue. Can you confirm the below package is also working for you?

live-sass-6.0.3-beta.1.zip

@florianPopulaer
Copy link
Author

Yes, it is working correctly now. That was fast 😊.

Thanks for the great support/tool!

@glenn2223
Copy link
Owner

Glad it's working! Will publish a patch soon

glenn2223 added a commit that referenced this issue Feb 24, 2023
@glenn2223
Correct source maps on new compiler
f3a821d 
Source maps (from the new compiler) are now working correctly - closes #276
glenn2223 added a commit that referenced this issue Feb 24, 2023
@glenn2223
v6.0.3
a08ae6b 
# 6.0.3 - 2023-02-24

<small>[Compare to previous release][comp:6.0.3]</small>

### Fixed

-   Using the new compiler (`liveSassCompile.settings.useNewCompiler`) outputs source maps correctly - Closes [#276](#276)

### Updated

-   `sass` to `1.58.3` [Changelog][cl:sa]
-   Various dev dependency updates _(nothing user facing)_

[comp:6.0.3]: v6.0.2...v6.0.3
[cl:sa]: https://github.com/sass/dart-sass/blob/main/CHANGELOG.md
@glenn2223 glenn2223 mentioned this issue Feb 24, 2023
Merged
glenn2223 added a commit that referenced this issue Feb 24, 2023
@glenn2223
v6.0.3
9bd70a8 
# 6.0.3 - 2023-02-24

<small>[Compare to previous release][comp:6.0.3]</small>

### Fixed

-   Using the new compiler (`liveSassCompile.settings.useNewCompiler`) outputs source maps correctly - Closes [#276](#276)

### Updated

-   `sass` to `1.58.3` [Changelog][cl:sa]
-   Various dev dependency updates _(nothing user facing)_


[comp:6.0.3]: v6.0.2...v6.0.3
[cl:sa]: https://github.com/sass/dart-sass/blob/main/CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v6.0.3 glenn2223/vscode-live-sass-compiler
2 participants
@glenn2223 @florianPopulaer