Fix splattributes handling of type attribute. [rebased] #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw someone mention #1178 and I noticed that it needed a rebase.
I looked into it and it seems that the re-architecturing work done in 8e11b91 actually removed the
template-compiler.tswhere the logic in the PR was implemented.I think I found the correct new place for it. After rebasing the tests provided by @thousand were failing on my machine, and after changing the logic everything went green.
@thousand thanks for your initial effort, I hope you don't mind my rebase. I tried pushing to your branch but didn't have permissions to do it.
Closes #1178.
Closes emberjs/ember.js#18232.