Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build @glimmer/debug, as no package should be using it during publish-time #1625

Merged
merged 8 commits into from
Oct 2, 2024

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Oct 1, 2024

An experiment

A way to test if certain text makes it in to dists:

ag --unrestricted --file-search-regex "dist/dev/index\\.js" "debugSlice\(" 

Copy link

github-actions bot commented Oct 1, 2024

duration phase no difference [-25ms to 110ms]
renderEnd phase no difference [-1ms to 2ms]
render1000Items1End phase no difference [-2ms to 15ms]
clearItems1End phase no difference [-3ms to 2ms]
render1000Items2End phase no difference [0ms to 15ms]
clearItems2End phase no difference [-1ms to 1ms]
render5000Items1End phase no difference [-1ms to 39ms]
clearManyItems1End phase estimated regression +4ms [2ms to 7ms] OR +1.8% [0.74% to 2.87%]
render5000Items2End phase no difference [-34ms to 22ms]
clearManyItems2End phase no difference [0ms to 4ms]
render1000Items3End phase no difference [-22ms to 4ms]
append1000Items1End phase no difference [-11ms to 29ms]
append1000Items2End phase estimated regression +13ms [1ms to 22ms] OR +1.72% [0.18% to 3%]
updateEvery10thItem1End phase no difference [0ms to 0ms]
updateEvery10thItem2End phase no difference [0ms to 0ms]
selectFirstRow1End phase no difference [0ms to 0ms]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [-1ms to 0ms]
removeSecondRow1End phase no difference [0ms to 0ms]
swapRows1End phase no difference [0ms to 0ms]
swapRows2End phase no difference [-1ms to 0ms]
clearItems4End phase no difference [-1ms to 2ms]
paint phase no difference [0ms to 0ms]

[23:24:53] Generating Benchmark Reports [started]
[23:25:01] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.html

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review October 1, 2024 22:18
@NullVoxPopuli NullVoxPopuli merged commit 48435a3 into main Oct 2, 2024
6 checks passed
@NullVoxPopuli NullVoxPopuli deleted the build-stuff branch October 2, 2024 14:55
@github-actions github-actions bot mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant