Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for circuit breaker to sync #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mauricioabreu
Copy link
Member

We are checking before it is opening/closing,
making out tests fail randomly.

We are checking before it is opening/closing,
making out tests fail randomly.
@mauricioabreu
Copy link
Member Author

Not sure why but it looks like we have some concurrency problem here. I am digging into hystrix's codebase to find the reason.

@mauricioabreu
Copy link
Member Author

Before merging it, I would like to debug our code instead of hystrix.

@mauricioabreu
Copy link
Member Author

I set a logger to check what hystrix is doing.

➜  reliable-request git:(master) ✗ go test -v -count=1 -run Test_It_closes_the_circuit_breaker_after_the_sleep_window ./...
=== RUN   Test_It_closes_the_circuit_breaker_after_the_sleep_window
hystrix-go: opening circuit %v[custom_cb]hystrix-go: allowing single test to possibly close circuit %v[custom_cb]hystrix-go: closing circuit %v[custom_cb]--- FAIL: Test_It_closes_the_circuit_breaker_after_the_sleep_window (3.50s)
    reliablereq_test.go:292: 
                Error Trace:    reliablereq_test.go:292
                Error:          Not equal: 
                                expected: true
                                actual  : false
                Test:           Test_It_closes_the_circuit_breaker_after_the_sleep_window
FAIL
FAIL    github.com/globocom/reliable-request/reliablereq        3.515s

@mauricioabreu mauricioabreu self-assigned this Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants