perf: Avoid recursing in gather_foralls

gluon-lang · Jan 27, 2019 · 6a38f43 · 6a38f43
1 parent 1713a44
commit 6a38f43
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/check/src/typecheck/generalize.rs b/check/src/typecheck/generalize.rs
@@ -3,7 +3,7 @@ use crate::base::{
     fnv::{FnvMap, FnvSet},
     pos::{BytePos, Span},
     symbol::Symbol,
-    types::{self, AppVec, ArcType, BuiltinType, Generic, Type, TypeInterner},
+    types::{self, AppVec, ArcType, BuiltinType, Flags, Generic, Type, TypeExt, TypeInterner},
 };
 
 use crate::{substitution::Substitution, typ::RcType, typecheck::Typecheck};
@@ -252,6 +252,12 @@ struct TypeVariableGenerator {
 impl TypeVariableGenerator {
     fn new(subs: &Substitution<RcType>, typ: &RcType) -> TypeVariableGenerator {
         fn gather_foralls(map: &mut FnvSet<Symbol>, subs: &Substitution<RcType>, typ: &RcType) {
+            if !typ
+                .flags()
+                .intersects(Flags::HAS_VARIABLES | Flags::HAS_FORALL)
+            {
+                return;
+            }
             let typ = subs.real(typ);
             if let Type::Forall(ref params, _) = **typ {
                 map.extend(params.iter().map(|param| param.id.clone()));