-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a serializer and deserializer from/to gluon values #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marwes
changed the title
Add a serializer and deserializer from/to gluon values
[WIP] Add a serializer and deserializer from/to gluon values
Jun 14, 2017
Marwes
force-pushed
the
serde_api
branch
2 times, most recently
from
June 19, 2017 19:44
9dc5584
to
9180a79
Compare
Reduces the size of the api module and lets the serde module use the macros in tests
The `Array` type do not store `Value` directly but instead creates `Value` types on demand. The actual data is still lives as long as the the array itself though so the `Variants` need to reflect that to work in deserialization
`ValueRef` shouldn't expose implementation details such as that
The `Deserialize` implementation can emit any errors about type mismatches so we do not need to do it in the `Deserializer`.
Also moves some serialization tests to doc tests.
Marwes
changed the title
[WIP] Add a serializer and deserializer from/to gluon values
feat: Add a serializer and deserializer from/to gluon values
Jun 19, 2017
@eldyer Feel free to test this out as a git dependency now, otherwise I will try to make a 0.5 release by the end of this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to easily marshal values to and from gluon by utilizing serde's serialization and deserialization.