Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repl): Don't panic on solo array literals #558

Merged
merged 2 commits into from
Jun 27, 2018

Conversation

Marwes
Copy link
Member

@Marwes Marwes commented Jun 26, 2018

As the repl invokes the typechecker without an expected type any array
in the tail expression would not get a type assigned to them.

Fixes #555

@Marwes
Copy link
Member Author

Marwes commented Jun 26, 2018

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 26, 2018

Merge conflict (retrying...)

@bors
Copy link
Contributor

bors bot commented Jun 26, 2018

Merge conflict

As the repl invokes the typechecker without an expected type any array
in the tail expression would not get a type assigned to them.

Fixes gluon-lang#555
Shouldn't be necessary anymore since lalrpop builds much faster now
@Marwes
Copy link
Member Author

Marwes commented Jun 27, 2018

bors r+

bors bot added a commit that referenced this pull request Jun 27, 2018
558: fix(repl): Don't panic on solo array literals r=Marwes a=Marwes

As the repl invokes the typechecker without an expected type any array
in the tail expression would not get a type assigned to them.

Fixes #555

Co-authored-by: Markus Westerlind <marwes91@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jun 27, 2018

Build succeeded

@bors bors bot merged commit 1ceed88 into gluon-lang:master Jun 27, 2018
@Marwes Marwes deleted the issue_555 branch June 27, 2018 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant