feat: Add CreatedAt and UpdatedAt to Ruleset (google#3316)

Fixes: google#3315.
gmlewis · Oct 8, 2024 · 13afa20 · 13afa20
1 parent 139eec8
commit 13afa20
Show file tree

Hide file tree

Showing 4 changed files with 55 additions and 3 deletions.
diff --git a/github/github-accessors.go b/github/github-accessors.go
diff --git a/github/github-accessors_test.go b/github/github-accessors_test.go
diff --git a/github/repos_rules.go b/github/repos_rules.go
@@ -548,6 +548,8 @@ type Ruleset struct {
 	Links        *RulesetLinks      `json:"_links,omitempty"`
 	Conditions   *RulesetConditions `json:"conditions,omitempty"`
 	Rules        []*RepositoryRule  `json:"rules,omitempty"`
+	UpdatedAt    *Timestamp         `json:"updated_at,omitempty"`
+	CreatedAt    *Timestamp         `json:"created_at,omitempty"`
 }
 
 // rulesetNoOmitBypassActors represents a GitHub ruleset object. The struct does not omit bypassActors if the field is nil or an empty array is passed.

diff --git a/github/repos_rules_test.go b/github/repos_rules_test.go
@@ -489,14 +489,18 @@ func TestRepositoriesService_GetAllRulesets(t *testing.T) {
 			  "name": "ruleset",
 			  "source_type": "Repository",
 			  "source": "o/repo",
-			  "enforcement": "enabled"
+			  "enforcement": "enabled",
+			  "created_at": `+referenceTimeStr+`,
+			  "updated_at": `+referenceTimeStr+`
 			},
 			{
 			  "id": 314,
 			  "name": "Another ruleset",
 			  "source_type": "Repository",
 			  "source": "o/repo",
-			  "enforcement": "enabled"
+			  "enforcement": "enabled",
+			  "created_at": `+referenceTimeStr+`,
+			  "updated_at": `+referenceTimeStr+`
 			}
 		]`)
 	})
@@ -514,13 +518,17 @@ func TestRepositoriesService_GetAllRulesets(t *testing.T) {
 			SourceType:  String("Repository"),
 			Source:      "o/repo",
 			Enforcement: "enabled",
+			CreatedAt:   &Timestamp{referenceTime},
+			UpdatedAt:   &Timestamp{referenceTime},
 		},
 		{
 			ID:          Int64(314),
 			Name:        "Another ruleset",
 			SourceType:  String("Repository"),
 			Source:      "o/repo",
 			Enforcement: "enabled",
+			CreatedAt:   &Timestamp{referenceTime},
+			UpdatedAt:   &Timestamp{referenceTime},
 		},
 	}
 	if !cmp.Equal(ruleSet, want) {
@@ -683,7 +691,9 @@ func TestRepositoriesService_GetRuleset(t *testing.T) {
 			"name": "ruleset",
 			"source_type": "Organization",
 			"source": "o",
-			"enforcement": "enabled"
+			"enforcement": "enabled",
+			"created_at": `+referenceTimeStr+`,
+			"updated_at": `+referenceTimeStr+`
 		}`)
 	})
 
@@ -699,6 +709,8 @@ func TestRepositoriesService_GetRuleset(t *testing.T) {
 		SourceType:  String("Organization"),
 		Source:      "o",
 		Enforcement: "enabled",
+		CreatedAt:   &Timestamp{referenceTime},
+		UpdatedAt:   &Timestamp{referenceTime},
 	}
 	if !cmp.Equal(ruleSet, want) {
 		t.Errorf("Repositories.GetRuleset returned %+v, want %+v", ruleSet, want)