Fix Mux.Find not correctly handling nested routes
#954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
LGTM.
@dils2k can you please give this a try and report back?
|
|
||
| if node != nil { | ||
| if node.subroutes == nil { | ||
| e := node.endpoints[m] |
There was a problem hiding this comment.
can this every panic?
would it be safer to e, ok := node.endpoints[m]
There was a problem hiding this comment.
@VojtechVitek No because mx.tree.FindRoute(rctx, m, path) will return nil if there is not a matching endpoint for the method.
Yup! It works. |
dils2k
reviewed
Sep 25, 2024
Comment on lines
+1853
to
+1857
| r.Route("/yo", func(r Router) { | ||
| r.Get("/sup", func(w http.ResponseWriter, r *http.Request) { | ||
| w.Write([]byte("sup")) | ||
| }) | ||
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #872 to fix
Mux.Findnot correctly handling nested routes (See #872 (comment)).