fix owner team permission

go-gitea · Apr 13, 2023 · 78fd2c2 · 78fd2c2
1 parent e197fc7
commit 78fd2c2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/models/organization/org.go b/models/organization/org.go
@@ -342,11 +342,15 @@ func CreateOrganization(org *Organization, owner *user_model.User) (err error) {
 	// insert units for team
 	units := make([]TeamUnit, 0, len(unit.AllRepoUnitTypes))
 	for _, tp := range unit.AllRepoUnitTypes {
+		up := perm.AccessModeOwner
+		if tp == unit.TypeExternalTracker || tp == unit.TypeExternalWiki {
+			up = perm.AccessModeRead
+		}
 		units = append(units, TeamUnit{
 			OrgID:      org.ID,
 			TeamID:     t.ID,
 			Type:       tp,
-			AccessMode: perm.AccessModeOwner,
+			AccessMode: up,
 		})
 	}
 

diff --git a/tests/integration/api_org_test.go b/tests/integration/api_org_test.go
@@ -60,14 +60,15 @@ func TestAPIOrgCreate(t *testing.T) {
 
 		for _, ut := range unit_model.AllRepoUnitTypes {
 			// WIP: need to confirm
+			up := perm.AccessModeOwner
 			if ut == unit_model.TypeExternalTracker || ut == unit_model.TypeExternalWiki {
-				continue
+				up = perm.AccessModeRead
 			}
 			unittest.AssertExistsAndLoadBean(t, &org_model.TeamUnit{
 				OrgID:      apiOrg.ID,
 				TeamID:     ownerTeam.ID,
 				Type:       ut,
-				AccessMode: perm.AccessModeOwner,
+				AccessMode: up,
 			})
 		}