Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libravatar, although enabled at install time, is not working #22325

Closed
strk opened this issue Jan 3, 2023 · 4 comments
Closed

Libravatar, although enabled at install time, is not working #22325

strk opened this issue Jan 3, 2023 · 4 comments
Labels

Comments

@strk
Copy link
Member

strk commented Jan 3, 2023

Description

I've deployed a new Gitea from current main branch v1.19.0-dev-263-gefa708501 and libravatar lookup is not occurring.

It may or may not be related to the recent deprecation of app.ini setting. The install procedure allows you to configure it and writes it into app.ini but evidently doesn't write it in database where it now belongs ?

Gitea Version

v1.19.0-dev-263-gefa708501

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

From build tree

Database

PostgreSQL

@strk strk added the type/bug label Jan 3, 2023
@strk
Copy link
Member Author

strk commented Jan 3, 2023

Things only work after I enable federated avatar from the admin screen, where it appears as disabled despite the corresponding checkbox being checked at install time. The database table system_setting did not contain any record with setting_key = picture.enable_federated_avatar which was taken by Gitea as meaning DISABLED . I guess the previous behavior was for the default to be ENABLED judging from the install screen checkbox being checked by default.

@strk
Copy link
Member Author

strk commented Jan 3, 2023

Another problem (needs a separate ticket?) is that you can NOT re-enable gravatar after disabling it from the admin screen, as it has no effect (reloading the page keeps shows the control turned on even if you try to turn it off)

@strk
Copy link
Member Author

strk commented Jan 3, 2023

I'm re-doing the process from scratch, from empty database and no app.ini -- doing so I realized that "libravatar" was NOT enabled by default, so I must have done that myself.

jolheiser added a commit that referenced this issue Jan 3, 2023
Related to #22325 

Signed-off-by: jolheiser <john.olheiser@gmail.com>
jolheiser added a commit to jolheiser/gitea that referenced this issue Jan 3, 2023
Related to go-gitea#22325 

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@strk
Copy link
Member Author

strk commented Jan 3, 2023

The libravatar enabling at install time is fixed by #22326 so I'm closing this. Will file a new ticket for the inability to change configuration.

@strk strk closed this as completed Jan 3, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant