Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot right or middle click notification background to follow the link #22692

Closed
Daeraxa opened this issue Jan 31, 2023 · 3 comments · Fixed by #22695
Closed

Cannot right or middle click notification background to follow the link #22692

Daeraxa opened this issue Jan 31, 2023 · 3 comments · Fixed by #22695
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@Daeraxa
Copy link

Daeraxa commented Jan 31, 2023

Description

The notification area has both a text link and a background "box" that, when left clicked, both take you to the same location.
However right or middle clicking this box does not open a new tab or give you a context menu to open in a new tab like you get if you were to right or middle click the text.

Screenshots

Right clicking the text:
image

Right clicking the box:
image

Gitea Version

1.18.3

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Linux Mint 21

Browser Version

Firefox 107.0.1

@Daeraxa Daeraxa added type/bug topic/ui Change the appearance of the Gitea UI labels Jan 31, 2023
@Eragonfr
Copy link

Isn't this expected ? The box is not a link but the text is, personally I really dislike when the whole box is a link. So the current state is what I want/expect from this notification list.
I can see that this could be a bug because there is the data-href tag but this doesn't mean that this should be a link.
Also the PR #22695 is a good way to fix this misunderstanding without modifying the current behavior.

@Daeraxa
Copy link
Author

Daeraxa commented Jan 31, 2023

Currently the entire box is a link but you can't right or middle click it as I stated in the issue detail so either way, it is wrong.
And I disagree, I think the row should be clickable but it should have the same options available to it as the text link, GitHub uses this style too and is a pretty standard UI thing.

@crystalcommunication
Copy link
Contributor

The link URL does not appear in the lower left of the browser when hovering over the background either. I assume this is due to it being some sort of Javascript to handle that area being clicked.

jolheiser added a commit that referenced this issue Mar 25, 2023
Resolves #22692

I don't think there's a need for this entire row to be clickable (and
even different links depending on which segment you click)
The links still point to the same spot, so no information is lost here.

---------

Signed-off-by: jolheiser <john.olheiser@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Mar 25, 2023
Resolves go-gitea#22692

I don't think there's a need for this entire row to be clickable (and
even different links depending on which segment you click)
The links still point to the same spot, so no information is lost here.

---------

Signed-off-by: jolheiser <john.olheiser@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
lafriks pushed a commit that referenced this issue Mar 25, 2023
Backport #22695 by @jolheiser

Resolves #22692

Signed-off-by: jolheiser <john.olheiser@gmail.com>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants