Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message new Branch(es) are ready to be merged #23743

Closed
uvulpos opened this issue Mar 27, 2023 · 12 comments · Fixed by #25715
Closed

Message new Branch(es) are ready to be merged #23743

uvulpos opened this issue Mar 27, 2023 · 12 comments · Fixed by #25715
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone

Comments

@uvulpos
Copy link

uvulpos commented Mar 27, 2023

Feature Description

As a developer, I want the ability to create pull requests fast. Therefore, I create a branch and switch then to the UI to click the button create a pull request. To improve my workflow, I would appreciate it if there was a banner to quickly create Pull Requests, like there is on GitHub.

Notes:

  • these messages should only appear for really newly created Branches, e.x. 1 hour
  • It is available on the main page of the code repository
  • Example: Example Image

Screenshots

No response

@uvulpos uvulpos added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Mar 27, 2023
@lunny
Copy link
Member

lunny commented Mar 27, 2023

Do you know Gitea will return a link to the git client, so you can just click the link to enter the process to create a pull request?

@yardenshoham
Copy link
Member

Many people use git UIs without looking the command line output when pushing so I support this

@wxiaoguang
Copy link
Contributor

Do you know Gitea will return a link to the git client, so you can just click the link to enter the process to create a pull request?

I never used that

@uvulpos
Copy link
Author

uvulpos commented Mar 27, 2023

I have to agree with @yardenshoham, I got used to the VSC Git Integration since I was kinda forced by my team to use a similar workflow and I don't have any console output for that. Thats why I need a button to do this for me 🙂

@lunny
Copy link
Member

lunny commented Mar 27, 2023

I'm not against this feature but just mentioned we have another one I used it frequently. I just sent a PR to improve the documentation. #23744

@delvh
Copy link
Member

delvh commented Mar 27, 2023

Additionally, the problem with the existing feature is that it is only triggered on the first commit.
Oftentimes, you want to have multiple commits before creating a PR.

@JakobDev
Copy link
Contributor

There are 2 another big problems:

  1. As long as no error happens, most people don't take a look at the output of commands like git push, that they use very often.
  2. If you use a Git GUI, you will most likely (depending on the GUI) see the Output of git push at all.

@uvulpos
Copy link
Author

uvulpos commented Mar 27, 2023

In the JetBrains Interface, there is a git tab at the bottom, but the VSCode git extension does not have this like mentioned before :)

@jpraet
Copy link
Member

jpraet commented Mar 27, 2023

Duplicate of #13196. There is a draft PR #14003

@uvulpos
Copy link
Author

uvulpos commented Mar 28, 2023

Oh, but at least we can make it alive again :)
Over 2 years sounds dead to me

@lunny
Copy link
Member

lunny commented Mar 29, 2023

Let's keep this one since there more discuss here. And I copied the issue content below from @kolaente

As a user, I would like to see a prompt on the home page or repository page to create a new PR if I recently pushed to a new branch for which no PR exists yet so that I save clicking on the "new PR" button on the repo page.

This could be done purely through the db without any git calls since we already have all the data in the action table.

I think we can always assume the user has the rights to create a PR if they have the right to push to a new branch in that repo, so no need to check that.
We would just need another check if the repo pushed to is a fork to check with the head repo if a PR exists there and not in the fork repo.

@kolaente
Copy link
Member

kolaente commented Apr 1, 2023

I've rebased and fixed a bunch of things in my PR #14003 - would appreciate a couple of eyeballs.

@lunny lunny added this to the 1.21.0 milestone Jul 6, 2023
6543 pushed a commit that referenced this issue Jul 8, 2023
This PR will display a pull request creation hint on the repository home
page when there are newly created branches with no pull request. Only
the recent 6 hours and 2 updated branches will be displayed.

Inspired by #14003 
Replace #14003 
Resolves #311
Resolves #13196
Resolves #23743

co-authored by @kolaente
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
8 participants