Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer dispaly issue #24249

Closed
yp05327 opened this issue Apr 21, 2023 · 11 comments · Fixed by #24251
Closed

Footer dispaly issue #24249

yp05327 opened this issue Apr 21, 2023 · 11 comments · Fixed by #24251
Labels
type/bug

Comments

@yp05327
Copy link
Contributor

yp05327 commented Apr 21, 2023 •
edited
Loading

Description

image

It seems that footer has been changed. (In the middle of the footer, not left and right)

Then if we adjust the browser's width:
image
It seems that there's an issue.

Gitea Version

1.20.0+dev-517-g948a9ee5e

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 21, 2023 •
edited
Loading

Maybe I changed some code and broke it ..... (not sure .... because I made many changes on this element)

I guess we could remove the ui container and fine-tune the footer left & right, it could be simpler

@yp05327
Copy link
Contributor Author

yp05327 commented Apr 21, 2023 •
edited
Loading

Tested in old version(release/v1.18) have no problems.
release/v1.19 have same problem

@wxiaoguang wxiaoguang mentioned this issue Apr 21, 2023
Merged
@wxiaoguang
Copy link
Contributor

Does this look good to you? Fix footer display #24251

silverwind added a commit that referenced this issue Apr 22, 2023
@wxiaoguang @silverwind @GiteaBot
Fix footer display (#24251)
7447b39 
Fix #24249

Diff with ignoring spaces:
https://github.com/go-gitea/gitea/pull/24251/files?diff=split&w=1

Screenshots:

<details>

<img width="1440" alt="image"
src="https://user-images.githubusercontent.com/2114189/233592840-d9ef7296-64eb-4e48-a598-300807a7c2f9.png">

<img width="923" alt="image"
src="https://user-images.githubusercontent.com/2114189/233593015-16edc531-43c2-4ff0-b27e-ca75dbadce0c.png">

</details>

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Giteabot <teabot@gitea.io>
wxiaoguang added a commit to wxiaoguang/gitea that referenced this issue Apr 22, 2023
@wxiaoguang @silverwind @GiteaBot
Fix footer display (go-gitea#24251)
2cbce4a 
Fix go-gitea#24249

Diff with ignoring spaces:
https://github.com/go-gitea/gitea/pull/24251/files?diff=split&w=1

Screenshots:

<details>

<img width="1440" alt="image"
src="https://user-images.githubusercontent.com/2114189/233592840-d9ef7296-64eb-4e48-a598-300807a7c2f9.png">

<img width="923" alt="image"
src="https://user-images.githubusercontent.com/2114189/233593015-16edc531-43c2-4ff0-b27e-ca75dbadce0c.png">

</details>

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Giteabot <teabot@gitea.io>
@wxiaoguang wxiaoguang mentioned this issue Apr 22, 2023
Closed
@wxiaoguang wxiaoguang mentioned this issue Apr 22, 2023
Merged
silverwind pushed a commit that referenced this issue Apr 22, 2023
@wxiaoguang @lafriks
Fix footer display (#24251) (#24269)
da44484 
Backport #24251

Fix #24249

Diff with ignoring spaces:
https://github.com/go-gitea/gitea/pull/24269/files?diff=split&w=1


Manually tested


![image](https://user-images.githubusercontent.com/2114189/233766806-18eb18ad-0c4d-44f7-b0fc-b40466c64445.png)

Co-authored-by: Lauris BH <lauris@nix.lv>
@yp05327
Copy link
Contributor Author

yp05327 commented Apr 24, 2023 •
edited
Loading

@wxiaoguang
When I was checking the question you asked in #23625 (comment),
I found that #24182 happend again.

Maybe the fix of this issue is related?
image
image

And private tag, user name also seems strange? Maybe no word break is better(at least the private tag)?

@yp05327
Copy link
Contributor Author

yp05327 commented Apr 24, 2023 •
edited
Loading

It seems that it also happens in the old version:
(gitea.com)
image

@yp05327 yp05327 mentioned this issue Apr 24, 2023
Closed
@wxiaoguang
Copy link
Contributor

Maybe the fix of this issue is related?

IMO it's not related. It seems that the "issue list" page width is larger than expected. So a new issue could be fine.

@silverwind
Copy link
Member

silverwind commented Apr 24, 2023 •
edited
Loading

Maybe it's time to find something better for dropdowns. Maybe https://github.com/github/details-menu-element, or even better, use tippy.

@wxiaoguang
Copy link
Contributor

It's not related to dropdown.

I think the page width problem is a regression of

Which look like a dirty pollution to existing CSS styles.

@silverwind
Copy link
Member

@yp05327 Share link to try page with issue?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 28, 2023 •
edited
Loading

Will be fixed by #24393 (together)

At that time, some people do not understand how to make styles work with Fomantic UI correctly.

@yp05327
Copy link
Contributor Author

yp05327 commented Apr 28, 2023

@silverwind
https://try.gitea.io/yp05327/longnamelongnamelongnamelongnamelongnamelongnamelongnamelongname/issues

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix footer display wxiaoguang/gitea
Fix footer display (#24251) wxiaoguang/gitea
3 participants
@silverwind @wxiaoguang @yp05327