Relation Paths in Orgmode don't get the Src Prefix #29668
Comments
ankitrgadiya
added a commit
to ankitrgadiya/gitea
that referenced
this issue
Mar 8, 2024
The internal links to other files in the repository were not rendering with the Src Prefix (/src/branch-name/file-path). This commit fixes that by using the `SrcLink` as base if available. Resolves go-gitea#29668
lafriks
pushed a commit
that referenced
this issue
Mar 10, 2024
The internal links to other files in the repository were not rendering with the Src Prefix (/src/branch-name/file-path). This commit fixes that by using the `SrcLink` as base if available. Resolves #29668
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this issue
Mar 10, 2024
The internal links to other files in the repository were not rendering with the Src Prefix (/src/branch-name/file-path). This commit fixes that by using the `SrcLink` as base if available. Resolves go-gitea#29668
KN4CK3R
pushed a commit
that referenced
this issue
Mar 10, 2024
Backport #29669 by @ankitrgadiya The internal links to other files in the repository were not rendering with the Src Prefix (/src/branch-name/file-path). This commit fixes that by using the `SrcLink` as base if available. Resolves #29668 Co-authored-by: Ankit R Gadiya <git@argp.in>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
In the Orgmode file, internal links to some other file in the repository are not rendered with the src link (/src/branch-name/tree-path) causing the links to break.
I was able to reproduce it on Demo instance. This is the link to the repository.
https://try.gitea.io/ankitrgadiya/org-links-bug/src/branch/main
It looks like this is happening because the
SrcLinkis not appended in the Base path. This is the code for Link Rendering in Markdown.https://github.com/go-gitea/gitea/blob/main/modules/markup/markdown/goldmark.go#L133-L138
Versus, this is the code for Link Rendering in Orgmode.
https://github.com/go-gitea/gitea/blob/main/modules/markup/orgmode/orgmode.go#L145-L148
Gitea Version
v1.21.7
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
Git Version
2.40.1
Operating System
Debian GNU/Linux 12
How are you running Gitea?
I'm using the official Docker Image and running Gitea using Docker Compose.
Database
SQLite
The text was updated successfully, but these errors were encountered: