Fix usage of removed jqXHR.success #11379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
approved these changes
May 11, 2020
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
May 11, 2020
GiteaBot
added
lgtm/done
lafriks
added
type/bug
lgtm/need 1
GiteaBot
added
lgtm/done
|
or should we send a new pull for refactor? |
|
It will conflict anyway |
|
But I removed closes part, refactor can be done anyway in other PR |
|
#11311 is superseded by #9451 anyway (#11311 (comment)), it was supposed to be only a fix until full Webauthn and its refactor is in place. It seems that @jonasfranz is working separately on Webauthn too #11311 (comment) |
6543
approved these changes
May 11, 2020
|
Make lg-tm work |
zeripath
added
the
skip-changelog
7 tasks
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Introduced by b57a735 via removal of jQuery-Migrate. This PR changes usage of .success on jqXHR to .done. Fixes go-gitea#11228 and few other places, such as removal of code comments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by b57a735 via removal of jQuery-Migrate.
This PR changes usage of
.successonjqXHRto.done.Fixes #11228 and few other places, such as removal of code comments.