Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop cloning unnecessarily on PR update #12839

Merged
merged 5 commits into from
Sep 15, 2020
Merged

Stop cloning unnecessarily on PR update #12839

merged 5 commits into from
Sep 15, 2020

Conversation

zeripath
Copy link
Contributor

Fix #12740

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Stop cloning unnecessarily on PR update
648eb3f 
Fix go-gitea#12740

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.13.0 milestone Sep 14, 2020
@zeripath
Remove unnecessary delete
47c1dcb 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
Merge remote-tracking branch 'origin/master' into fix-12740-stop-clon…
c1c81d3 
…ing-on-pr-update
@zeripath
fix lint
5505cc0 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2020 •
edited
Loading

Codecov Report

Merging #12839 into master will increase coverage by 0.00%.
The diff coverage is 78.57%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12839   +/-   ##
=======================================
  Coverage   43.16%   43.16%           
=======================================
  Files         654      654           
  Lines       72218    72192   -26     
=======================================
- Hits        31176    31165   -11     
+ Misses      35987    35980    -7     
+ Partials     5055     5047    -8
Impacted Files Coverage Δ
services/pull/pull.go 41.27% <78.57%> (-0.76%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
services/pull/patch.go 66.37% <0.00%> (-2.59%) ⬇️
services/pull/check.go 48.46% <0.00%> (-2.31%) ⬇️
modules/git/repo.go 47.71% <0.00%> (-1.53%) ⬇️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
modules/git/utils.go 77.04% <0.00%> (+3.27%) ⬆️
modules/git/repo_language_stats.go 56.60% <0.00%> (+3.77%) ⬆️
modules/indexer/stats/queue.go 76.47% <0.00%> (+11.76%) ⬆️
modules/indexer/stats/db.go 69.56% <0.00%> (+26.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a905f...3671112. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 14, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 14, 2020
lunny
lunny approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if this will fix that bug, but it's also a performance improvement.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 15, 2020
@techknowlogick techknowlogick merged commit 342e49e into go-gitea:master Sep 15, 2020
@techknowlogick
Copy link
Member

@zeripath please send backport :)

@zeripath zeripath deleted the fix-12740-stop-cloning-on-pr-update branch September 15, 2020 06:06
zeripath added a commit to zeripath/gitea that referenced this pull request Sep 15, 2020
@zeripath
Stop cloning unnecessarily on PR update (go-gitea#12839)
7bd754d 
Backport go-gitea#12839

Fix go-gitea#12740

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Sep 15, 2020
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label Sep 15, 2020
lafriks pushed a commit that referenced this pull request Sep 15, 2020
@zeripath
Stop cloning unnecessarily on PR update (#12839) (#12852)
ff9d99f 
Backport #12839

Fix #12740

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

[Bug] PullRequest: merge base branch into feature branch cause "broken fork" and other errors
6 participants
@zeripath @codecov-commenter @techknowlogick @lunny @lafriks @GiteaBot