Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Prohibit automatic downgrades (#13108) #13111

Merged
merged 5 commits into from
Oct 12, 2020
Merged

[Backport] Prohibit automatic downgrades (#13108) #13111

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66dc315
Prohibit automatic downgrades
6543 Oct 12, 2020
8ffa892
do not only log, print to stderr too
6543 Oct 12, 2020
a723c06
Update models/migrations/migrations.go
6543 Oct 12, 2020
3b2e9bf
Update models/migrations/migrations.go
zeripath Oct 12, 2020
55b6d6e
a nit
6543 Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions models/migrations/migrations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ package migrations

import (
"fmt"
"os"
"regexp"
"strings"

Expand Down Expand Up @@ -290,12 +291,16 @@ Please try upgrading to a lower version first (suggested v1.6.4), then upgrade t
return nil
}

// Downgrading Gitea's database version not supported
if int(v-minDBVersion) > len(migrations) {
// User downgraded Gitea.
currentVersion.Version = int64(len(migrations) + minDBVersion)
_, err = x.ID(1).Update(currentVersion)
return err
msg := fmt.Sprintf("Downgrading database version from '%d' to '%d' is not supported and may result in loss of data integrity.\nIf you really know what you're doing, execute `UPDATE version SET version=%d WHERE id=1;`\n",
v, minDBVersion+len(migrations), minDBVersion+len(migrations))
fmt.Fprint(os.Stderr, msg)
log.Fatal(msg)
return nil
}

// Migrate
for i, m := range migrations[v-minDBVersion:] {
log.Info("Migration[%d]: %s", v+int64(i), m.Description())
if err = m.Migrate(x); err != nil {
Expand Down