Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase reading blame lines to 1MB. Fixes #12440 #13192

Closed
wants to merge 1 commit into from
Closed

Increase reading blame lines to 1MB. Fixes #12440 #13192

wants to merge 1 commit into from

Conversation

42wim
Copy link
Member

@42wim 42wim commented Oct 17, 2020

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #13192 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13192   +/-   ##
=======================================
  Coverage   42.01%   42.01%           
=======================================
  Files         683      683           
  Lines       75215    75217    +2     
=======================================
+ Hits        31602    31606    +4     
+ Misses      38448    38446    -2     
  Partials     5165     5165
Impacted Files Coverage Δ
modules/git/blame.go 76.27% <100.00%> (+0.83%) ⬆️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
routers/repo/view.go 38.11% <0.00%> (+0.64%) ⬆️
services/pull/check.go 52.55% <0.00%> (+0.72%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc8697...1361671. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 17, 2020
@CirnoT
Copy link
Contributor

CirnoT commented Oct 19, 2020

Aside from increasing the limit, how will this fix underlying issue?

zeripath added a commit to zeripath/gitea that referenced this pull request Nov 8, 2020
@zeripath
Prevent panic on git blame by limiting lines to 4096 bytes at most
c3602de 
Fix go-gitea#12440
Closes go-gitea#13192

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Nov 8, 2020
Merged
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Nov 9, 2020
@zeripath @6543
Prevent panic on git blame by limiting lines to 4096 bytes at most
39aa06b 
Fix go-gitea#12440
Closes go-gitea#13192

Signed-off-by: Andrew Thornton <art27@cantab.net>
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Nov 9, 2020
@zeripath @6543
Prevent panic on git blame by limiting lines to 4096 bytes at most
939762e 
Fix go-gitea#12440
Closes go-gitea#13192

Signed-off-by: Andrew Thornton <art27@cantab.net>
techknowlogick added a commit that referenced this pull request Nov 10, 2020
@zeripath @techknowlogick
Prevent panic on git blame by limiting lines to 4096 bytes at most (#…
182b5a0 
…13470)

Fix #12440
Closes #13192

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
techknowlogick added a commit to techknowlogick/gitea that referenced this pull request Nov 10, 2020
@zeripath @techknowlogick
Prevent panic on git blame by limiting lines to 4096 bytes at most (g…
09ccbad 
…o-gitea#13470)

Fix go-gitea#12440
Closes go-gitea#13192

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
techknowlogick added a commit to techknowlogick/gitea that referenced this pull request Nov 10, 2020
@zeripath @techknowlogick
Prevent panic on git blame by limiting lines to 4096 bytes at most (g…
17d5cd4 
…o-gitea#13470)

Fix go-gitea#12440
Closes go-gitea#13192

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
This was referenced Nov 10, 2020
Closed
Closed
zeripath added a commit that referenced this pull request Nov 10, 2020
@6543 @zeripath
Prevent panic on git blame by limiting lines to 4096 bytes at most (#…
4a71d4d 
…13492)

Fix #12440
Closes #13192

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit that referenced this pull request Nov 10, 2020
@6543 @zeripath
Prevent panic on git blame by limiting lines to 4096 bytes at most (#…
8049de8 
…13491)

Fix #12440
Closes #13192

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@42wim @codecov-io @CirnoT @GiteaBot