-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12897 - add mastodon provider #13293
#12897 - add mastodon provider #13293
Conversation
You need to add changes also in: |
Awesome!! Thanks for the PR :) A few things:
|
@techknowlogick I have applied all the suggestions except handling of a custom instance URL. I see that for providers with the custom URL mapping enabled, we have specific endpoints you can customize like the authURL and tokenURL. For mastodon, should we not do any of that and just have the ability to specify a custom instanceURL i.e. something like this: I will also have to another field to the CustomURLMapping struct for InstanceURL, correct? |
Yup :)
You could use an existing field (I recommend using AuthURL), but pass it to |
@techknowlogick unable to add you as reviewer but please take a look. Also, is drone down? The automated check doesn't seem to be running. |
Co-authored-by: techknowlogick <matti@mdranta.net>
Codecov Report
@@ Coverage Diff @@
## master #13293 +/- ##
==========================================
+ Coverage 42.10% 42.14% +0.04%
==========================================
Files 689 689
Lines 75721 75771 +50
==========================================
+ Hits 31881 31933 +52
- Misses 38610 38621 +11
+ Partials 5230 5217 -13
Continue to review full report at Codecov.
|
…s-stored-in-email-address-table * origin/master: [UI] Hide consecutive additions and removals of the same label (go-gitea#13315) [skip ci] Updated translations via Crowdin Fix send mail (go-gitea#13312) [skip ci] Updated translations via Crowdin Deny wrong pull (go-gitea#13308) Group Label Changed Comments in timeline (go-gitea#13304) [skip ci] Updated translations via Crowdin Attempt to handle unready PR in tests (go-gitea#13305) go-gitea#12897 - add mastodon provider (go-gitea#13293) [skip ci] Updated translations via Crowdin Fix Storage mapping (go-gitea#13297) Update Mirror IsEmpty status on synchronize (go-gitea#13185) Fix bug isEnd detection on getIssues/getPullRequests (go-gitea#13299) systemd service: Add commented PATH environment option for Git prefix (go-gitea#13170) Sendmail command (go-gitea#13079) Various UI and arc-green fixes (go-gitea#13291)
This PR targets #12897. I included the Mastodon provider in oauth2.go and I am looking for feedback on if I have added (and vendored) the module correctly. The diff seems to be very large and I am wondering if that's normal when adding a new module.