Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect on project after issue created #17211

Merged
merged 6 commits into from
Oct 5, 2021
Merged

Redirect on project after issue created #17211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1aaa769
Redirect on project after issue created
romdum Oct 3, 2021
0af4e42
Code review - Remove redirect_on_project param in URL (#17211)
romdum Oct 3, 2021
34a7201
Code review - Change variable redirect_on_project by redirection_afte…
romdum Oct 3, 2021
6849c8c
Code review - Change variable redirection_after_creation by redirect_…
romdum Oct 3, 2021
43b3ad9
Merge branch 'main' into feature/redirect_on_project
6543 Oct 5, 2021
11696b2
Merge branch 'main' into feature/redirect_on_project
6543 Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion routers/web/repo/issue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,6 +803,9 @@ func NewIssue(ctx *context.Context) {
ctx.Data["Project"] = project
}

if len(ctx.Req.URL.Query().Get("project")) > 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this is unnecessary? The POST requests will also request the current URL. So that the query strings are still there.

Copy link
Contributor

@wxiaoguang wxiaoguang Oct 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue edit form's action is filled by {{.Link}}, without query string. So this parameter is necessary.

ctx.Data["redirect_after_creation"] = "project"
}
}

RetrieveRepoMetas(ctx, ctx.Repo.Repository, false)
Expand Down Expand Up @@ -990,7 +993,11 @@ func NewIssuePost(ctx *context.Context) {
}

log.Trace("Issue created: %d/%d", repo.ID, issue.ID)
ctx.Redirect(ctx.Repo.RepoLink + "/issues/" + fmt.Sprint(issue.Index))
if ctx.FormString("redirect_after_creation") == "project" {
ctx.Redirect(ctx.Repo.RepoLink + "/projects/" + fmt.Sprint(form.ProjectID))
} else {
ctx.Redirect(ctx.Repo.RepoLink + "/issues/" + fmt.Sprint(issue.Index))
}
}

// commentTag returns the CommentTag for a comment in/with the given repo, poster and issue
Expand Down
1 change: 1 addition & 0 deletions templates/repo/issue/new_form.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,5 +236,6 @@
{{end}}
</div>
</div>
<input type="hidden" name="redirect_after_creation" value="{{.redirect_after_creation}}">
</div>
</form>