Converts columns from NULL to NOT NULL DEFAULT

models/auth/webauthn.go

@@ -46,8 +46,8 @@ type WebAuthnCredential struct {
 	PublicKey       []byte
 	AttestationType string
 	AAGUID          []byte
-	SignCount       uint32 `xorm:"BIGINT"`
-	CloneWarning    bool
+	SignCount       uint32             `xorm:"BIGINT"`
+	CloneWarning    bool               `xorm:"NOT NULL DEFAULT false"`
 	CreatedUnix     timeutil.TimeStamp `xorm:"INDEX created"`
 	UpdatedUnix     timeutil.TimeStamp `xorm:"INDEX updated"`
 }

models/fixtures/repository.yml

@@ -16,6 +16,7 @@
   num_watches: 4
   num_projects: 1
   num_closed_projects: 0
+  is_mirror: false
   status: 0
 
 -
@@ -33,6 +34,7 @@
   num_closed_pulls: 0
   num_stars: 1
   close_issues_via_commit_in_any_branch: true
+  is_mirror: false
   status: 0
 
 -
@@ -41,6 +43,7 @@
   owner_name: user3
   lower_name: repo3
   name: repo3
+  is_archived: false
   is_empty: false
   is_private: true
   num_issues: 1
@@ -50,6 +53,7 @@
   num_watches: 0
   num_projects: 1
   num_closed_projects: 0
+  is_mirror: false
   status: 0
 
 -
@@ -67,6 +71,7 @@
   num_stars: 1
   num_projects: 0
   num_closed_projects: 1
+  is_mirror: false
   status: 0
 
 -
@@ -224,6 +229,7 @@
   name: repo15
   is_empty: false
   is_private: true
+  is_mirror: false
   status: 0
 
 -
@@ -239,6 +245,7 @@
   num_pulls: 0
   num_closed_pulls: 0
   num_watches: 0
+  is_mirror: false
   status: 0
 
 -
@@ -495,6 +502,7 @@
   name: utf8
   is_empty: false
   is_private: false
+  is_mirror: false
   status: 0
 
 -
@@ -618,7 +626,7 @@
   num_forks: 0
   num_issues: 1
   num_milestones: 1
-  is_mirror:
+  is_mirror: false
   is_archived: false
 
 -
@@ -738,6 +746,7 @@
   num_watches: 0
   num_projects: 0
   num_closed_projects: 0
+  is_mirror: false
   status: 0
 
 -
@@ -758,6 +767,7 @@
   num_watches: 0
   num_projects: 0
   num_closed_projects: 0
+  is_mirror: false
   status: 0
 
 -
@@ -768,4 +778,5 @@
   name: empty
   is_empty: true
   is_private: true
+  is_mirror: false
   status: 0

models/fixtures/user.yml

@@ -497,6 +497,7 @@
   avatar: avatar27
   avatar_email: user27@example.com
   num_repos: 3
+  is_active: true
 
 -
   id: 28

models/issues/issue.go

@@ -106,25 +106,25 @@ type Issue struct {
 	RepoID           int64                  `xorm:"INDEX UNIQUE(repo_index)"`
 	Repo             *repo_model.Repository `xorm:"-"`
 	Index            int64                  `xorm:"UNIQUE(repo_index)"` // Index in one repository.
-	PosterID         int64                  `xorm:"INDEX"`
+	PosterID         int64                  `xorm:"INDEX NOT NULL DEFAULT 0"`
 	Poster           *user_model.User       `xorm:"-"`
 	OriginalAuthor   string
-	OriginalAuthorID int64                  `xorm:"index"`
+	OriginalAuthorID int64                  `xorm:"INDEX NOT NULL DEFAULT 0"`
 	Title            string                 `xorm:"name"`
 	Content          string                 `xorm:"LONGTEXT"`
 	RenderedContent  string                 `xorm:"-"`
 	Labels           []*Label               `xorm:"-"`
-	MilestoneID      int64                  `xorm:"INDEX"`
+	MilestoneID      int64                  `xorm:"INDEX NOT NULL DEFAULT 0"`
 	Milestone        *Milestone             `xorm:"-"`
 	Project          *project_model.Project `xorm:"-"`
-	Priority         int
-	AssigneeID       int64            `xorm:"-"`
-	Assignee         *user_model.User `xorm:"-"`
-	IsClosed         bool             `xorm:"INDEX"`
-	IsRead           bool             `xorm:"-"`
-	IsPull           bool             `xorm:"INDEX"` // Indicates whether is a pull request or not.
-	PullRequest      *PullRequest     `xorm:"-"`
-	NumComments      int
+	Priority         int                    `xorm:"NOT NULL DEFAULT 0"`
+	AssigneeID       int64                  `xorm:"-"`
+	Assignee         *user_model.User       `xorm:"-"`
+	IsClosed         bool                   `xorm:"INDEX NOT NULL DEFAULT false"`
+	IsRead           bool                   `xorm:"-"`
+	IsPull           bool                   `xorm:"INDEX NOT NULL DEFAULT false"` // Indicates whether is a pull request or not.
+	PullRequest      *PullRequest           `xorm:"-"`
+	NumComments      int                    `xorm:"NOT NULL DEFAULT 0"`
 	Ref              string
 
 	DeadlineUnix timeutil.TimeStamp `xorm:"INDEX"`

models/issues/label.go

@@ -79,9 +79,9 @@ type Label struct {
 	OrgID           int64 `xorm:"INDEX"`
 	Name            string
 	Description     string
-	Color           string `xorm:"VARCHAR(7)"`
-	NumIssues       int
-	NumClosedIssues int
+	Color           string             `xorm:"VARCHAR(7)"`
+	NumIssues       int                `xorm:"NOT NULL DEFAULT 0"`
+	NumClosedIssues int                `xorm:"NOT NULL DEFAULT 0"`
 	CreatedUnix     timeutil.TimeStamp `xorm:"INDEX created"`
 	UpdatedUnix     timeutil.TimeStamp `xorm:"INDEX updated"`
 

models/issues/milestone.go

@@ -47,12 +47,12 @@ type Milestone struct {
 	Name            string
 	Content         string `xorm:"TEXT"`
 	RenderedContent string `xorm:"-"`
-	IsClosed        bool
-	NumIssues       int
-	NumClosedIssues int
-	NumOpenIssues   int  `xorm:"-"`
-	Completeness    int  // Percentage(1-100).
-	IsOverdue       bool `xorm:"-"`
+	IsClosed        bool   `xorm:"NOT NULL DEFAULT false"`
+	NumIssues       int    `xorm:"NOT NULL DEFAULT 0"`
+	NumClosedIssues int    `xorm:"NOT NULL DEFAULT 0"`
+	NumOpenIssues   int    `xorm:"-"`
+	Completeness    int    `xorm:"NOT NULL DEFAULT 0"` // Percentage(1-100).
+	IsOverdue       bool   `xorm:"-"`
 
 	CreatedUnix    timeutil.TimeStamp `xorm:"INDEX created"`
 	UpdatedUnix    timeutil.TimeStamp `xorm:"INDEX updated"`

models/migrations/migrations.go

@@ -415,6 +415,8 @@ var migrations = []Migration{
 	NewMigration("Alter gpg_key/public_key content TEXT fields to MEDIUMTEXT", alterPublicGPGKeyContentFieldsToMediumText),
 	// v226 -> v227
 	NewMigration("Conan and generic packages do not need to be semantically versioned", fixPackageSemverField),
+	// v227 -> v228
+	NewMigration("Convert columns from NULL to NOT NULL DEFAULT", convertFromNullToDefault),
 }
 
 // GetCurrentDBVersion returns the current db version
@@ -981,8 +983,8 @@ func dropTableColumns(sess *xorm.Session, tableName string, columnNames ...strin
 	return nil
 }
 
-// modifyColumn will modify column's type or other property. SQLITE is not supported
-func modifyColumn(x *xorm.Engine, tableName string, col *schemas.Column) error {
+// modifyColumns will modify columns type or other property. SQLITE is not supported
+func modifyColumns(x *xorm.Engine, tableName string, cols ...*schemas.Column) error {
 	var indexes map[string]*schemas.Index
 	var err error
 	// MSSQL have to remove index at first, otherwise alter column will fail
@@ -1010,9 +1012,13 @@ func modifyColumn(x *xorm.Engine, tableName string, col *schemas.Column) error {
 		}
 	}()
 
-	alterSQL := x.Dialect().ModifyColumnSQL(tableName, col)
-	if _, err := x.Exec(alterSQL); err != nil {
-		return err
+	for _, col := range cols {
+		alterSQL := x.Dialect().ModifyColumnSQL(tableName, col)
+		if _, err := x.Exec(alterSQL); err != nil {
+			log.Error("Error modifying column: %v", col.Name)
+			return err
+		}
 	}
+
 	return nil
 }

models/migrations/v165.go

@@ -19,7 +19,7 @@ func convertHookTaskTypeToVarcharAndTrim(x *xorm.Engine) error {
 		Typ string `xorm:"VARCHAR(16) index"`
 	}
 
-	if err := modifyColumn(x, "hook_task", &schemas.Column{
+	if err := modifyColumns(x, "hook_task", &schemas.Column{
 		Name: "typ",
 		SQLType: schemas.SQLType{
 			Name: "VARCHAR",
@@ -45,7 +45,7 @@ func convertHookTaskTypeToVarcharAndTrim(x *xorm.Engine) error {
 		Type string `xorm:"VARCHAR(16) index"`
 	}
 
-	if err := modifyColumn(x, "webhook", &schemas.Column{
+	if err := modifyColumns(x, "webhook", &schemas.Column{
 		Name: "type",
 		SQLType: schemas.SQLType{
 			Name: "VARCHAR",

models/migrations/v179.go

@@ -16,7 +16,7 @@ func convertAvatarURLToText(x *xorm.Engine) error {
 	}
 
 	// Some oauth2 providers may give very long avatar urls (i.e. Google)
-	return modifyColumn(x, "external_login_user", &schemas.Column{
+	return modifyColumns(x, "external_login_user", &schemas.Column{
 		Name: "avatar_url",
 		SQLType: schemas.SQLType{
 			Name: schemas.Text,

models/migrations/v205.go

@@ -16,7 +16,7 @@ func migrateUserPasswordSalt(x *xorm.Engine) error {
 		return nil
 	}
 
-	if err := modifyColumn(x, "user", &schemas.Column{
+	if err := modifyColumns(x, "user", &schemas.Column{
 		Name: "rands",
 		SQLType: schemas.SQLType{
 			Name: "VARCHAR",
@@ -29,7 +29,7 @@ func migrateUserPasswordSalt(x *xorm.Engine) error {
 		return err
 	}
 
-	return modifyColumn(x, "user", &schemas.Column{
+	return modifyColumns(x, "user", &schemas.Column{
 		Name: "salt",
 		SQLType: schemas.SQLType{
 			Name: "VARCHAR",