Improve Stopwatch behavior #18930
Merged
Improve Stopwatch behavior #18930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gusted
commented
Feb 27, 2022
•
Gusted
commented
- Don't send empty stopwatch over and over again, only send once.
- Stop interval to update stopwatch's timer when there is no more stopwatch.
- Don't send empty stopwatch over and over again, only send once. - Stop interval to update stopwatch's timer when there is no more stopwatch.
Gusted
added
type/enhancement
|
Tagging performance/cpu as it doesn't have to send data over HTTP for most use-cases(user which are logged in but don't have any stopwatches/timers). |
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Feb 27, 2022
GiteaBot
added
lgtm/need 1
delvh
reviewed
Feb 27, 2022
wxiaoguang
reviewed
Feb 27, 2022
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
delvh
approved these changes
Feb 28, 2022
GiteaBot
added
lgtm/done
|
PR has changed pretty significant since e769c24 please re-check., |
Gusted
commented
Feb 28, 2022
jpraet
reviewed
Mar 15, 2022
zeripath
reviewed
Mar 19, 2022
Signed-off-by: Andrew Thornton <art27@cantab.net>
|
Test failure is related. |
added 2 commits
March 28, 2022 02:08
|
Should be all good now. |
|
At this point we're torturing the CI server every so often with new commits, time to get it merged? |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 26, 2022
* giteaofficial/main: Add a new menu in file view to open blame view and fix blame view select range bug (go-gitea#19500) Fix two UI bugs: JS error in imagediff.js, 500 error in diff/compare.tmpl [skip ci] Updated translations via Crowdin Improve Stopwatch behavior (go-gitea#18930) Pass gitRepo down to GetRawDiff, since its used for main repo and wiki (go-gitea#19461) Use queue instead of memory queue in webhook send service (go-gitea#19390) add a directory prefix `gitea-src-VERSION` to release-tar-file (go-gitea#19396)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
- Don't send empty stopwatch over and over again, only send once. - Stop interval to update stopwatch's timer when there is no more stopwatch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.