Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor mirror code & fix StartToMirror (#18904) #19075

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Refactor mirror code & fix StartToMirror (#18904) #19075

merged 1 commit into from
Mar 14, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Mar 14, 2022

@Gusted Gusted added this to the 1.16.4 milestone Mar 14, 2022
@Gusted Gusted requested a review from lunny March 14, 2022 09:34
@Gusted Gusted added type/bug pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! labels Mar 14, 2022
6543
6543 approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Ack that we need to backport, but because it is breaking it do have a bad taste ... we need to communicate this clear

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 14, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 14, 2022
@lunny lunny merged commit 66b8a43 into go-gitea:release/v1.16 Mar 14, 2022
@lunny
Copy link
Member

lunny commented Mar 14, 2022

The potential break is when those instances have tasks in the mirror disk queue when upgrading.

@6543
Copy link
Member

6543 commented Mar 14, 2022

I know ... just oint that up to admins on release info

@Gusted Gusted deleted the backport-fix-mirrors branch March 14, 2022 13:03
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/bug
Projects
None yet
Milestone
1.16.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Gusted @lunny @6543 @GiteaBot