Do not send notification emails to inactive users (part 2) #19142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately fixing changes to `mail_issue.go` did not get included in go-gitea#19131. We also need to not send issue comment mails to deactivated users. Fix go-gitea#18950 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
skip-changelog
6543
approved these changes
Mar 19, 2022
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Mar 19, 2022
GiteaBot
added
lgtm/done
zeripath
changed the title
zeripath
added a commit
that referenced
this pull request
Mar 19, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 21, 2022
* giteaofficial/main: Add 1.18 (go-gitea#19151) [skip ci] Updated translations via Crowdin Fix NPE `/repos/issues/search` when not signed in (go-gitea#19154) [skip ci] Updated licenses and gitignores Use custom favicon when viewing static files if it exists (go-gitea#19130) not send notification emails to inactive users (part 2) (go-gitea#19142) Make migrations SKIP_TLS_VERIFY apply to git too (go-gitea#19132) Do not send notification emails to inactive users (go-gitea#19131)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Unfortunately fixing changes to `mail_issue.go` did not get included in go-gitea#19131. We also need to not send issue comment mails to deactivated users. Fix go-gitea#18950 Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately fixing changes to
mail_issue.godid not get included in #19131.We also need to not send issue comment mails to deactivated users.
Fix #18950
Signed-off-by: Andrew Thornton art27@cantab.net