Add auto logging of goroutine pid label #19212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR uses unsafe to export the hidden runtime_getProfLabel function from the runtime package and then casts the result to a map[string]string. We can then interrogate this map to get the pid label from the goroutine allowing us to log it with any logging request. Reference go-gitea#19202 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
logging-goroutine-pid-label
branch
from
e1fed29
to
b819116
Compare
Signed-off-by: Andrew Thornton <art27@cantab.net>
|
This one may be quite controversial and I've put it up as an example of something that we might want to consider doing. |
GiteaBot
added
the
lgtm/need 2
wxiaoguang
approved these changes
Mar 26, 2022
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Mar 26, 2022
GiteaBot
added
lgtm/done
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
|
make L-G-T-M work. |
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* Add auto logging of goroutine pid label This PR uses unsafe to export the hidden runtime_getProfLabel function from the runtime package and then casts the result to a map[string]string. We can then interrogate this map to get the pid label from the goroutine allowing us to log it with any logging request. Reference go-gitea#19202 Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
unsafeto export the hiddenruntime_getProfLabelfunction from theruntimepackage and then casts the result to amap[string]string.We can then interrogate this map to get the
pidlabel from the goroutine allowingus to log it with any logging request.
Reference #19202
Signed-off-by: Andrew Thornton art27@cantab.net