Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy unknwon/com package #19298

Merged
merged 5 commits into from
Apr 1, 2022

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Apr 1, 2022

Follows:

Changes:

  • The CopyDir is only used inside test code
  • Rewrite ToSnakeCase with more test cases
  • The RedisCacher was not well designed, it only put strings into cache, here we use toStr function to replace the legacy ToStr
  • The UniqueQueue can use string as ID directly, no need to call ToStr

@wxiaoguang wxiaoguang added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 1, 2022
@wxiaoguang wxiaoguang added this to the 1.17.0 milestone Apr 1, 2022
@wxiaoguang wxiaoguang force-pushed the remove-legacy-com branch 3 times, most recently from 4421530 to adbbaa5 Compare April 1, 2022 13:34
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 1, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@58c9d12). Click here to learn what that means.
The diff coverage is 51.08%.

@@           Coverage Diff           @@
##             main   #19298   +/-   ##
=======================================
  Coverage        ?   47.42%           
=======================================
  Files           ?      942           
  Lines           ?   131356           
  Branches        ?        0           
=======================================
  Hits            ?    62294           
  Misses          ?    61560           
  Partials        ?     7502           
Impacted Files Coverage Δ
cmd/manager_logging.go 0.00% <ø> (ø)
modules/cache/cache_redis.go 2.15% <0.00%> (ø)
modules/nosql/manager.go 46.42% <ø> (ø)
modules/util/legacy.go 40.00% <28.57%> (ø)
services/webhook/webhook.go 48.81% <33.33%> (ø)
models/unittest/fscopy.go 37.70% <37.70%> (ø)
models/unittest/testdb.go 15.62% <50.00%> (ø)
modules/sync/unique_queue.go 35.84% <54.54%> (ø)
modules/context/csrf.go 64.82% <55.55%> (ø)
modules/util/string.go 89.65% <89.65%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58c9d12...d5e2472. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 1, 2022
@wxiaoguang wxiaoguang merged commit 4f27c28 into go-gitea:main Apr 1, 2022
@wxiaoguang wxiaoguang deleted the remove-legacy-com branch April 1, 2022 16:35
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 3, 2022
* giteaofficial/main:
  Remove legacy unmaintained packages, refactor to support change default locale (go-gitea#19308)
  [skip ci] Updated translations via Crowdin
  Prevent intermittent NPE in queue tests (go-gitea#19301)
  Upgrade xorm/builder from v0.3.9 to v0.3.10 (go-gitea#19296)
  An attempt to sync a non-mirror repo must give 400 (Bad Request) (go-gitea#19300)
  Remove legacy `unknwon/com` package (go-gitea#19298)
  Improve package registry docs (go-gitea#19273)
  A pull-mirror repo should be marked as such on creation (go-gitea#19295)
  Refactor legacy `unknwon/com` package, improve golangci lint (go-gitea#19284)
  Skip frontend ROOT_URL check on installation page, remove unnecessary global var (go-gitea#19291)
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants