Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hostname:port to pass host matcher's check (#19543) #19544

Merged

Conversation

wxiaoguang
Copy link
Contributor

Backport #19543

Before: ip:port or hostname:port won't be matched.

Now we split the hostname from the hostname:port string, use the correct hostname to do the match.

@wxiaoguang wxiaoguang added this to the 1.16.7 milestone Apr 28, 2022
@wxiaoguang wxiaoguang changed the title support hostname:port Support hostname:port to pass host matcher's check #19543 Apr 28, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 28, 2022
@wxiaoguang wxiaoguang changed the title Support hostname:port to pass host matcher's check #19543 Support hostname:port to pass host matcher's check (#19543) Apr 28, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 28, 2022
@wxiaoguang wxiaoguang merged commit b86606f into go-gitea:release/v1.16 Apr 28, 2022
@wxiaoguang wxiaoguang deleted the backport-hostmacher-hostport branch April 28, 2022 17:42
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Apr 28, 2022
…go-gitea#19544)

Backport go-gitea#19543 
hostmatcher: split the hostname from the hostname:port string, use the correct hostname to do the match.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants