Only set CanColorStdout / CanColorStderr to true if the stdout/stderr is a terminal #19581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
force-pushed
the
fix-console-color
branch
from
2759920
to
312efad
Compare
6543
approved these changes
May 3, 2022
GiteaBot
added
the
lgtm/need 1
delvh
approved these changes
May 3, 2022
GiteaBot
added
lgtm/done
|
🚀 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 4, 2022
* giteaofficial/main: Fix broken TR on cherrypick page (go-gitea#19599) Use correct context in `routers/web` (go-gitea#19597) Use for a repo action one database transaction (go-gitea#19576) Only set CanColorStdout / CanColorStderr to true if the stdout/stderr is a terminal (go-gitea#19581) Don't fetch Mirror when it's migrating (go-gitea#19588) Move user password verification after checking his groups on ldap auth (go-gitea#19587)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running gitea as a systemd unit with logging set to console, the output should not be colorized,
otherwise it spams the journal / syslog with escape sequences like
#033[0m#033[32mcmd/web.go:102:#033[32mThis PR adds IsTerminal checks for non-WIndows platforms. For Windows, it was already done correctly in
console_window.goClose #19469