Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce eslint-plugin-jquery #19690

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

silverwind
Copy link
Member

Introduce the plugin that allows us to gradually forbid jQuery code. I've enabled all rules that already pass.

Next step will be to go through each rule and fix the issues by using native DOM equivalents, which I think can be done in separate PRs, but if prefered I could also start here.

Introduce the plugin that allows us to gradually forbid jQuery code.
I've enabled all rules that already pass.

Next step will be to go through each rule and fix the issues by using
native DOM equivalents, which I think can be done in separate PRs, but
if prefered I could also start here.
@silverwind silverwind added topic/ui Change the appearance of the Gitea UI topic/code-linting labels May 12, 2022
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 12, 2022
@6543 6543 added this to the 1.17.0 milestone May 12, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 12, 2022
@lunny lunny merged commit e45738e into go-gitea:main May 12, 2022
@silverwind silverwind deleted the plugin-nojquery branch May 12, 2022 16:13
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 13, 2022
* giteaofficial/main:
  Use a better OlderThan for DeleteInactiveUsers (go-gitea#19693)
  [skip ci] Updated translations via Crowdin
  Introduce eslint-plugin-jquery (go-gitea#19690)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
Introduce the plugin that allows us to gradually forbid jQuery code.
I've enabled all rules that already pass.

Next step will be to go through each rule and fix the issues by using
native DOM equivalents, which I think can be done in separate PRs, but
if prefered I could also start here.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants