Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency in doctor output #19836

Merged
merged 4 commits into from
May 31, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented May 29, 2022

  • Use logger.Info instead of logger.Warn when no errors were found.

Before:
image

After:
image

- Use `logger.Info` instead of `logger.Warn` when no errors were found.
@Gusted Gusted added this to the 1.17.0 milestone May 29, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 29, 2022
modules/doctor/fix16961.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 29, 2022
@techknowlogick techknowlogick merged commit 0e51694 into go-gitea:main May 31, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 1, 2022
* giteaofficial/main:
  Fix spelling mistake in ProcReceive (go-gitea#19853)
  Ensure responses are context.ResponseWriters (go-gitea#19843)
  Fix inconsistency in doctor output (go-gitea#19836)
  docs: recommendations to ensure backup consistency and reliability (go-gitea#19845)
  feat: Add support for extra sshd_config parameters via 'Include' file (go-gitea#19842)
  [skip ci] Updated translations via Crowdin
  docs: update the ROOT documentation and error messages (go-gitea#19832)
@Gusted Gusted deleted the fix-doctor-output branch June 15, 2022 12:16
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
* Fix inconsistency in doctor output

- Use `logger.Info` instead of `logger.Warn` when no errors were found.

* Update modules/doctor/fix16961.go

Co-authored-by: delvh <dev.lh@web.de>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants