Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some code into models/git #19879

Merged
merged 12 commits into from
Jun 12, 2022
Merged

Move some code into models/git #19879

merged 12 commits into from
Jun 12, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 3, 2022

depends on #19711 to move lfs related code.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jun 3, 2022
@Gusted Gusted modified the milestones: 1.17.0, 1.18.0 Jun 6, 2022
@lunny lunny changed the title WIP: move some code into models/git Move some code into models/git Jun 7, 2022
@lunny lunny modified the milestones: 1.18.0, 1.17.0 Jun 7, 2022
@lunny
Copy link
Member Author

lunny commented Jun 7, 2022

Since it's a refactor and PASS CI, I moved it to v1.17

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 7, 2022
@lunny lunny requested review from KN4CK3R, wxiaoguang and 6543 and removed request for wxiaoguang June 7, 2022 15:33
KN4CK3R
KN4CK3R reviewed Jun 7, 2022
View reviewed changes
models/git/branches.go Outdated Show resolved Hide resolved
models/git/branches_test.go Show resolved Hide resolved
models/git/lfs.go Outdated Show resolved Hide resolved
routers/web/repo/repo.go Outdated Show resolved Hide resolved
@techknowlogick techknowlogick modified the milestones: 1.17.0, 1.18.0 Jun 8, 2022
delvh
delvh reviewed Jun 9, 2022
View reviewed changes
models/git/branches.go Outdated Show resolved Hide resolved
models/git/branches.go Outdated Show resolved Hide resolved
models/branch.go Show resolved Hide resolved
@lunny lunny mentioned this pull request Jun 10, 2022
Merged
@lunny
Copy link
Member Author

lunny commented Jun 10, 2022

@KN4CK3R @delvh Both done.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 11, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 12, 2022
@lunny
Copy link
Member Author

lunny commented Jun 12, 2022

make L-G-T-m work

@lunny lunny modified the milestones: 1.18.0, 1.17.0 Jun 12, 2022
@lunny lunny merged commit 110fc57 into go-gitea:main Jun 12, 2022
@lunny lunny deleted the lunny/model_git branch June 12, 2022 15:51
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 13, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
1bdfd75 
* giteaofficial/main:
  Add deprecated log when using MySQL with utf8 charset (go-gitea#19952)
  Move issues related files into models/issues (go-gitea#19931)
  fix: some typos (go-gitea#19956)
  [skip ci] Updated translations via Crowdin
  Move some code into models/git (go-gitea#19879)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@lunny @AbdulrhmnGhanem
Move some code into models/git (go-gitea#19879)
1cf7bb7 
* Move access and repo permission to models/perm/access

* fix test

* Move some git related files into sub package models/git

* Fix build

* fix git test

* move lfs to sub package

* move more git related functions to models/git

* Move functions sequence

* Some improvements per @KN4CK3R and @delvh
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@delvh delvh delvh approved these changes

@6543 6543 Awaiting requested review from 6543

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @KN4CK3R @delvh @techknowlogick @GiteaBot @Gusted