npm packages: set repository link based on the url in package.json #20379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
changed the title
silverwind
reviewed
Jul 15, 2022
GiteaBot
added
the
lgtm/need 2
Gusted
reviewed
Jul 18, 2022
KN4CK3R
reviewed
Jul 18, 2022
KN4CK3R
reviewed
Jul 20, 2022
Gusted
reviewed
Jul 20, 2022
Mai-Lapyst
requested review from
KN4CK3R and
Gusted
and removed request for
KN4CK3R
|
I think people were just waiting for the comments to resolve. Are they? |
|
They are resolved from my understanding; just wanted to give the commentors some time to look through it and mark it themselves. My bad. Have marked all as resolved. |
silverwind
reviewed
Sep 5, 2022
silverwind
reviewed
Sep 5, 2022
silverwind
reviewed
Sep 5, 2022
silverwind
reviewed
Sep 5, 2022
silverwind
approved these changes
Sep 5, 2022
GiteaBot
added
lgtm/need 1
KN4CK3R
reviewed
Sep 10, 2022
lunny
reviewed
Sep 13, 2022
lunny
reviewed
Sep 13, 2022
…the repository url present inside package.json; closes go-gitea#20146
… setting npm-package repo-link
…to avoid confusion
…n into a toplevel one
…default return for getRepositoryURLPathSegments()
…metadata if the type isn't git
Mai-Lapyst
force-pushed
the
npm-automatic-repositoryLink
branch
from
8f17b52
to
bf25dc2
Compare
|
Rebased onto main |
Mai-Lapyst
requested review from
lunny and
Gusted
and removed request for
Gusted and
lunny
lunny
approved these changes
Mar 28, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
🎺 🤖 |
jolheiser
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 29, 2023
* upstream/main: Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (go-gitea#23687) Add CSS rules for basic colored labels (go-gitea#23774) Add meilisearch support (go-gitea#23136) Add missing translation for `actions.runners.reset_registration_token_success` (go-gitea#23732) [skip ci] Updated translations via Crowdin Implement Issue Config (go-gitea#20956) Set repository link based on the url in package.json for npm packages (go-gitea#20379) Add API to manage issue dependencies (go-gitea#17935) Add creation time in tag list page (go-gitea#23693) Make minio package support legacy MD5 checksum (go-gitea#23768) Yarden Shoham has a new email address (go-gitea#23767) fix br display for packages curls (go-gitea#23737)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
automatically set repository link for package based on the repository url present inside package.json
closes #20146