Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment on PrivateUsers option for gitea.service #20383

Merged
merged 5 commits into from
Jul 16, 2022
Merged

Comment on PrivateUsers option for gitea.service #20383

merged 5 commits into from
Jul 16, 2022

Conversation

CLanguagePurist
Copy link
Contributor

A user happens to encounter an issue where PrivateUsers sandboxed Gitea.service and it effectively stop systemd from applying capabilities for that gitea.service. I am opening this PR to provide comments on PrivateUsers, effectively a tiny FAQ information for end-user.

A user happens to encounter an issue where PrivateUsers sandboxed Gitea.service and it effectively stop systemd from applying capabilities for that gitea.service. I am opening this PR to provide comments on PrivateUsers, effectively a tiny FAQ information for end-user.
@Gusted Gusted added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jul 15, 2022
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 15, 2022
Co-authored-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 15, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 15, 2022
@6543 6543 added this to the 1.18.0 milestone Jul 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #20383 (f925d34) into main (fee0e4d) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #20383      +/-   ##
==========================================
+ Coverage   46.88%   46.90%   +0.01%     
==========================================
  Files         976      976              
  Lines      135193   135193              
==========================================
+ Hits        63384    63408      +24     
+ Misses      64040    64017      -23     
+ Partials     7769     7768       -1     
Impacted Files Coverage Δ
modules/git/repo_base_nogogit.go 70.58% <0.00%> (-3.93%) ⬇️
modules/git/utils.go 66.29% <0.00%> (-3.38%) ⬇️
models/issues/comment.go 50.00% <0.00%> (-0.44%) ⬇️
services/pull/pull.go 40.18% <0.00%> (-0.16%) ⬇️
modules/queue/workerpool.go 55.95% <0.00%> (+1.03%) ⬆️
models/notification.go 63.32% <0.00%> (+1.09%) ⬆️
modules/notification/ui/ui.go 60.71% <0.00%> (+1.78%) ⬆️
modules/log/event.go 60.27% <0.00%> (+2.09%) ⬆️
modules/notification/mail/mail.go 43.83% <0.00%> (+2.73%) ⬆️
modules/queue/queue_channel.go 83.33% <0.00%> (+2.77%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8e06f...f925d34. Read the comment docs.

@6543 6543 merged commit 6247a1d into go-gitea:main Jul 16, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 18, 2022
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Comment on PrivateUsers option for gitea.service (go-gitea#20383)
  [skip ci] Updated translations via Crowdin
  Remove confusing TrimPrefix(... git.BranchPrefix) (go-gitea#20369)
  Set target on create release with existing tag (go-gitea#20381)
  Initialize cron last (go-gitea#20373)
  Allow access to the Public Organization Member lists with minimal permissions (go-gitea#20330)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
* Comment on PrivateUsers option for gitea.service

A user happens to encounter an issue where PrivateUsers sandboxed Gitea.service and it effectively stop systemd from applying capabilities for that gitea.service. I am opening this PR to provide comments on PrivateUsers, effectively a tiny FAQ information for end-user.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants