Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dashboard navbar dropdown overflow #20389

Closed
wants to merge 1 commit into from
Closed

Fix dashboard navbar dropdown overflow #20389

wants to merge 1 commit into from

Conversation

lhsazevedo
Copy link
Contributor

Fixes #20039.

Preview

User dashboard:
user dashboard preview image

Organization dashboard:
organization dashboard preview image

I guess it's ok to use no-vertical-tabs here for now, as the vertical layout was already broken in the organization dashboard:

View current broken org vertical tabs

Screen Shot 2022-07-16 at 04 37 20

@6543 6543 added topic/ui Change the appearance of the Gitea UI type/bug labels Jul 16, 2022
@6543 6543 added this to the 1.18.0 milestone Jul 16, 2022
@lhsazevedo
Copy link
Contributor Author

lhsazevedo commented Jul 17, 2022 •
edited
Loading

It looks like it was introduced in #19486. @Gusted Could you confirm that this is a good fix?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 17, 2022
@Gusted
Copy link
Contributor

Gusted commented Jul 18, 2022

I already have a fix at #20238 ~ Which could be converted into #20393 (a more elegant solution to overflows)

@silverwind
Copy link
Member

This is using a menu, which I don't intend to replace in first pass of popup removal. But it should definitely be possible to handle menu as well using tippy.

@lhsazevedo
Copy link
Contributor Author

Okay, thanks. I'll experiment tippy tonight

@lhsazevedo lhsazevedo closed this Jul 18, 2022
@lunny lunny removed this from the 1.18.0 milestone Dec 20, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch Dashboard Context dropdown not opening on mobile web ui
6 participants
@lhsazevedo @Gusted @silverwind @lunny @GiteaBot @6543